refactor(www): Factor out modal to its own component #21330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tesseralis
commented
Feb 10, 2020
| @@ -46,21 +46,16 @@ class StarterTemplate extends React.Component { | |||
| !this.state.showAllDeps && allDeps.length - shownDeps.length > 0 | |||
|
|
|||
| // plug for now | |||
| const isModal = false | |||
There was a problem hiding this comment.
Since this isn't being used, I'm deleting it. If we ever wanted a modal for this, it would probably be something like creating a <ModalLayout> component that has the switch between the normal layout and the modal.
sidharthachatterjee
approved these changes
Feb 10, 2020
sidharthachatterjee
changed the title
sidharthachatterjee
added
the
bot: merge on green
This was referenced Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Factor out the modal part of
<Layout>into its own<Modal>component.TODO: further refactors of the ShowcaseDetails component. The primary thing here is simplifying the component.
Motivation
The
<Layout>component is used in nearly all pages on gatsbyjs.org and we can get rid of a lot of its cruft, since theisModalprop is only used for the showcase (and at some point starters?).Screenshots
Modal view:
Non-modal view: