refactor(www): Reorganize plugin pages layout #21337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tesseralis
changed the title
tesseralis
commented
Feb 10, 2020
| ) | ||
| } | ||
| return <>{props.children}</> | ||
| export default function Layout({ children }) { |
There was a problem hiding this comment.
We could delete this file, but we're going to move src/components/Layout here.
sidharthachatterjee
approved these changes
Feb 10, 2020
sidharthachatterjee
changed the title
sidharthachatterjee
added
the
bot: merge on green
This was referenced Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reorganize the way the plugin pages/templates use layouts:
@loadable/componentinstead of our custom thinggatsby-nodeandlayouts/index.js