Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(www): Simplify code for site showcase #21352

Merged
merged 8 commits into from
Feb 11, 2020
Merged

refactor(www): Simplify code for site showcase #21352

merged 8 commits into from
Feb 11, 2020

Conversation

tesseralis
Copy link
Contributor

Description

  • Move more prev/next logic inside the <Modal> component
  • Move all the logic for calculating prev/next in a hook rather than passing in props from parent

@tesseralis tesseralis requested a review from a team as a code owner February 10, 2020 21:35
@tesseralis tesseralis removed the request for review from adcar February 10, 2020 21:35
@tesseralis tesseralis changed the title refactor (www) Simplify code for starter showcase refactor (www) Simplify code for site showcase Feb 10, 2020
@tesseralis tesseralis changed the title refactor (www) Simplify code for site showcase refactor(www): Simplify code for site showcase Feb 11, 2020
sidharthachatterjee
sidharthachatterjee approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 🥇 🥇

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Feb 11, 2020
@gatsbybot gatsbybot merged commit 9f4ea7f into gatsbyjs:master Feb 11, 2020
This was referenced Feb 14, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tesseralis @sidharthachatterjee @gatsbybot