Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(www): inherit from layout in ecosystem page and fix weird styling #21358

Merged
merged 2 commits into from
Feb 11, 2020
Merged

fix(www): inherit from layout in ecosystem page and fix weird styling #21358

merged 2 commits into from
Feb 11, 2020

Conversation

tesseralis
Copy link
Contributor

Description

Fix weird styling in gatsbyjs.org/ecosystem by inheriting from the same Layout used everywhere else.

The current /ecosystem page has some issues:

Screen Shot 2020-02-10 at 7 44 38 PM

  • The link to "Gatsby Cloud" in the banner is double-underlined
  • All text is slightly more bold than in all other pages of the site

By pulling in the normal <Layout> component and making some adjustments, we resolve these issues:

Screen Shot 2020-02-10 at 7 44 46 PM

@tesseralis tesseralis requested a review from a team as a code owner February 11, 2020 03:48
@tesseralis tesseralis changed the title fix(www) inherit from layout in ecosystem page and fix weird styling fix(www): inherit from layout in ecosystem page and fix weird styling Feb 11, 2020
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are the real MVP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants