-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs]: Guide on working with Etsy in Gatsby #21580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started on this and then realized @AishaBlake should do this one. But figured I'd leave the start of what I did!
The overarching recommendation is that this reads more like a tutorial than a reference doc. Take a look at the reference doc guide for help with understanding the difference.
Co-Authored-By: LB <barth.laurie@gmail.com>
Co-Authored-By: LB <barth.laurie@gmail.com>
Sent this without a comment unintentionally. Roll with these suggestions for now and maybe Marcy can help if there's no option to open a test store without providing your bank info. We should make sure each section is as accurate as possible before merging! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be a really great addition to the Gatsby docs! I left some comments about the content we need to see as part of this PR. Please let us know if you have any questions.
Co-Authored-By: LB <barth.laurie@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking better! I've left some comments to elicit more context, as this is one of the first docs of its kind so it presents an opportunity to really guide Gatsby users toward an e-commerce solution. We want to inspire them on what to do next if possible, even if the doc only shows a basic sourcing setup in detail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these are additions or adjustments to things Marcy's already said. I think the only new thing that needs to be changed is the capitalization of "title" in the frontmatter!
Co-Authored-By: Aisha Blake <aisha@gatsbyjs.com>
Co-Authored-By: Aisha Blake <aisha@gatsbyjs.com>
Co-Authored-By: Aisha Blake <aisha@gatsbyjs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great Aisha! Left some comments/suggestions below.
In particular, I tried to soften the advantages section some. I think this still gets across the benefits of Gatsby in this situation, but let me know if you disagree.
Co-Authored-By: LB <laurie@gatsbyjs.com>
One last thing based on the alt text explanation. But other than that this is good to go! |
Co-Authored-By: LB <laurie@gatsbyjs.com>
Looks great! |
Description
Reference Guide on working with Etsy in Gatsby.
Related Issues
New guide on working with Etsy #20226