Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(www): Organize components in dot-org based on use #21683

Closed
wants to merge 4 commits into from

Conversation

DallasGale
Copy link
Contributor

Description

Re-organized the www/src/components/* files to be grouped into new & existing sub-folders.

Related Issues

Fixes #21331
Related to #19105

@DallasGale DallasGale requested review from a team as code owners February 23, 2020 01:06
@tesseralis tesseralis changed the title Topics/www 21331 refactor(www): Refactor components in dot-org Feb 23, 2020
@tesseralis tesseralis changed the title refactor(www): Refactor components in dot-org refactor(www): Organize components in dot-org based on use Feb 23, 2020
@DallasGale DallasGale self-assigned this Feb 23, 2020
@DallasGale
Copy link
Contributor Author

Hey @tesseralis Just checking in about this PR. It looks like the conflicts need to be resolved on your end ?

@DallasGale
Copy link
Contributor Author

Hey @tesseralis. Is there anything I need to do to help get this one over the line? The Resolve conflicts button is disabled for me so I cant resolve the conflicts.

@tesseralis
Copy link
Contributor

Hi @DallasGale, unfortunately it seems like there has been enough conflicts here that it might just be easier to start from the beginning. As a suggestion, I think it would be better to make smaller PRs, one for each folder/section. This will make it easier for us to review the PR and get it merged in, and reduce the chance of conflicts happening.

@tesseralis
Copy link
Contributor

tesseralis commented May 11, 2020

Since this branch has fallen out of step with master and has too many conflicts, I'll close it out for now. @DallasGale if you'd like to reimplement this PR per my suggestion (separate PRs for each section) we would welcome your contribution!

@tesseralis thanks, I will look at it again in the next couple of days.

@tesseralis tesseralis closed this May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(www) Organize components in dot-org by section
3 participants