Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme with information for multiple spaces #21740

Merged
merged 7 commits into from
Mar 10, 2020

Conversation

alex-tgk
Copy link
Contributor

Added in an explanation for sourcing from multiple Contentful environments/spaces. This is a topic I have seen come up multiple times in the community so I thought it warranted adding it here.

Description

Documentation

Related Issues

Added in an explanation for sourcing from multiple Contentful environments/spaces. This is a topic I have seen come up multiple times in the community so I thought it warranted adding it here.
@alex-tgk alex-tgk requested a review from a team as a code owner February 25, 2020 18:29
@laurieontech
Copy link
Contributor

Thanks for the PR!

I noticed that you have a couple uses of "simple" in your current text. As the styleguide suggests it would be great to replace those (or remove them) to make the write up more approachable.

Really appreciate your contributions!

@alex-tgk
Copy link
Contributor Author

Thanks for the PR!

I noticed that you have a couple uses of "simple" in your current text. As the styleguide suggests it would be great to replace those (or remove them) to make the write up more approachable.

Really appreciate your contributions!

No problem! Updated with more concise verbiage.

Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! Made one suggestion but this looks good. Next step is to verify it. Will add it to the list of PRs for review.

packages/gatsby-source-contentful/README.md Outdated Show resolved Hide resolved
Co-Authored-By: LB <laurie@gatsbyjs.com>
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed this works. My only request is to mark the gatsby-config.js filename in backticks so it reads as code in a paragraph. Otherwise this is good to go! Thanks for the PR!

packages/gatsby-source-contentful/README.md Outdated Show resolved Hide resolved
@laurieontech laurieontech added status: awaiting author response Additional information has been requested from the author type: documentation An issue or pull request for improving or updating Gatsby's documentation labels Mar 10, 2020
Added ` to gatsby-config.js
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks for the PR!

@marcysutton marcysutton merged commit 94247c1 into gatsbyjs:master Mar 10, 2020
@gatsbot
Copy link

gatsbot bot commented Mar 10, 2020

Holy buckets, @alex-tgk — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting author response Additional information has been requested from the author type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants