-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Readme with information for multiple spaces #21740
Conversation
Added in an explanation for sourcing from multiple Contentful environments/spaces. This is a topic I have seen come up multiple times in the community so I thought it warranted adding it here.
Thanks for the PR! I noticed that you have a couple uses of "simple" in your current text. As the styleguide suggests it would be great to replace those (or remove them) to make the write up more approachable. Really appreciate your contributions! |
No problem! Updated with more concise verbiage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates! Made one suggestion but this looks good. Next step is to verify it. Will add it to the list of PRs for review.
Co-Authored-By: LB <laurie@gatsbyjs.com>
Co-Authored-By: Khaled Garbaya <khaledgarbaya@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've confirmed this works. My only request is to mark the gatsby-config.js
filename in backticks so it reads as code in a paragraph. Otherwise this is good to go! Thanks for the PR!
Added ` to gatsby-config.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thanks for the PR!
Holy buckets, @alex-tgk — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Added in an explanation for sourcing from multiple Contentful environments/spaces. This is a topic I have seen come up multiple times in the community so I thought it warranted adding it here.
Description
Documentation
Related Issues