Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-transformer-sharp) remove default export #21777

Merged

Conversation

skovhus
Copy link
Contributor

@skovhus skovhus commented Feb 26, 2020

Description

This PR fixes a recent regression introduced in #20782, where a mix of import and require caused file extension warnings (e.g. You can't use childImageSharp together with x.png — use publicURL instead. The childImageSharp portion of the query in this file).

Related Issues

Fixed #21776

Next steps

I would love to introduce more safety nets in the code to avoid this problem in the future. Any plans to embrace TypeScript? Or limit the mix of import, default export, export, module.exports and require (this could be done using eslint)?

Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR! Seems like I goofed up there, sorry for that. We'll most likely switch our codebase to TS over time so in the future this (confusing) mix should be solved. Anyways, will publish quickly 👍

@LekoArts LekoArts merged commit 35b0c3b into gatsbyjs:master Feb 27, 2020
@gatsbot
Copy link

gatsbot bot commented Feb 27, 2020

Holy buckets, @skovhus — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@LekoArts
Copy link
Contributor

Fixed in gatsby-transformer-sharp@2.3.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gatsby-transformer-sharp 2.3.15 regression: You can't use childImageSharp together with
2 participants