Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refractor(www): Use nodes in gatsbyjs.org code instead of edges.node #21792

Merged
merged 1 commit into from
Feb 29, 2020
Merged

refractor(www): Use nodes in gatsbyjs.org code instead of edges.node #21792

merged 1 commit into from
Feb 29, 2020

Conversation

b0nbon1
Copy link
Contributor

@b0nbon1 b0nbon1 commented Feb 27, 2020

Description

Replacing where there are edges.node on the docs codes to nodes to maintain Code cleanliness of the gatsby website.

Related Issues

Fixes issue #21255

@b0nbon1 b0nbon1 requested a review from a team as a code owner February 27, 2020 09:29
tesseralis
tesseralis previously approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@tesseralis tesseralis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you so much for this. Just make sure to format the files correctly with prettier and fix the conflicts and we should be good to go :)

www/src/views/starter-library/filtered-starters.js Outdated Show resolved Hide resolved
@b0nbon1 b0nbon1 requested review from a team as code owners February 28, 2020 04:12
@b0nbon1 b0nbon1 force-pushed the use-nodes-instead-edges-graphql branch 2 times, most recently from a2e4b0c to 1650606 Compare February 28, 2020 04:48
@b0nbon1 b0nbon1 force-pushed the use-nodes-instead-edges-graphql branch from 1650606 to 8a90c53 Compare February 28, 2020 05:53
@b0nbon1 b0nbon1 requested review from tesseralis and removed request for a team February 28, 2020 05:55
KyleAMathews
KyleAMathews approved these changes Feb 29, 2020
View reviewed changes
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@KyleAMathews KyleAMathews merged commit fda78f1 into gatsbyjs:master Feb 29, 2020
@gatsbot
Copy link

gatsbot bot commented Feb 29, 2020

Holy buckets, @b0nbon1 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@LesleyLai LesleyLai mentioned this pull request Feb 29, 2020
Closed
@b0nbon1 b0nbon1 deleted the use-nodes-instead-edges-graphql branch March 1, 2020 08:58
This was referenced Mar 3, 2020
Closed
Merged
pvdz added a commit that referenced this pull request Mar 4, 2020
@pvdz
fix(www): starters is already a node
14427cd 
The `starters` array used to be an array of edges and is "now" an array of nodes so accessing `.node` is no longer necessary. So dropping the access should make it work again.

Fixes #21942

Bug was introduced by #21792
@pvdz pvdz mentioned this pull request Mar 4, 2020
Merged
This was referenced Mar 17, 2020
Open
Open
@praveenweb praveenweb mentioned this pull request Apr 20, 2020
Closed
@LekoArts LekoArts mentioned this pull request May 31, 2020
Merged
This was referenced Oct 6, 2020
Open
Open
@ajesse11x ajesse11x mentioned this pull request Feb 23, 2021
Open
@saurabharch saurabharch mentioned this pull request Feb 23, 2021
Open
@snyk-bot snyk-bot mentioned this pull request May 19, 2022
Open
@ajesse11x ajesse11x mentioned this pull request May 29, 2022
Open
This was referenced Jul 21, 2022
Open
Open
@ajesse11x ajesse11x mentioned this pull request Aug 24, 2022
Open
@saurabharch saurabharch mentioned this pull request Nov 27, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Nov 29, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Apr 16, 2024
Open
@saurabharch saurabharch mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tesseralis tesseralis tesseralis approved these changes

@KyleAMathews KyleAMathews KyleAMathews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@b0nbon1 @KyleAMathews @tesseralis