Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] TypeScript Refactor #21798

Merged
merged 3 commits into from
Mar 5, 2020
Merged

[RFC] TypeScript Refactor #21798

merged 3 commits into from
Mar 5, 2020

Conversation

blainekasten
Copy link
Contributor

@blainekasten blainekasten commented Feb 27, 2020 •
edited
Loading

TypeScript Refactor

Rendered RFC

@blainekasten blainekasten requested a review from a team as a code owner February 27, 2020 18:12
pvdz
pvdz previously approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just merge after fixing the typos.
I mean, you can fix the tests too if you want but I don't think this PR relates to them failing ;)

Thanks!

@pvdz
Copy link
Contributor

pvdz commented Feb 27, 2020

(I don't know whether learning is supposed to take a look at these...?)

@dominicfallows dominicfallows requested review from dominicfallows and removed request for dominicfallows February 28, 2020 14:26
@dominicfallows
Copy link
Contributor

+1 it would be great to start having strongly typed code in the core.

@blainekasten blainekasten merged commit 252b2dc into master Mar 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the rfc/typescript-refactor.md branch March 5, 2020 18:45
@blainekasten blainekasten mentioned this pull request Mar 5, 2020
Merged
@blainekasten blainekasten mentioned this pull request Mar 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tesseralis tesseralis tesseralis left review comments

@pvdz pvdz pvdz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blainekasten @pvdz @dominicfallows @tesseralis