Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(gatsby-plugin-preload-fonts): add external chrome env var #21845

Merged
merged 3 commits into from
Feb 29, 2020
Merged

docs(gatsby-plugin-preload-fonts): add external chrome env var #21845

merged 3 commits into from
Feb 29, 2020

Conversation

nibtime
Copy link
Contributor

@nibtime nibtime commented Feb 28, 2020

Description

A hint, that Puppeteer can be configured with environment variables, which is required in some configurations (e.g. Alpine Linux)

Related Issues

fixes #21778

@nibtime nibtime requested a review from a team as a code owner February 28, 2020 21:21
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Great addition to the Readme of this plugin. Thank you! 🙏

@wardpeet wardpeet changed the title docs( gatsby-plugin-preload-fonts): hint to Puppeteer environment var… docs(gatsby-plugin-preload-fonts): add external chrome env var Feb 29, 2020
@wardpeet wardpeet merged commit 8256fd4 into gatsbyjs:master Feb 29, 2020
@gatsbot
Copy link

gatsbot bot commented Feb 29, 2020

Holy buckets, @nibtime — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gatsby-plugin-preload-fonts] Make puppeteer script compatible with Alpine
2 participants