Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: add jsparty + gatsby post #22024

Merged
merged 5 commits into from
Mar 10, 2020
Merged

Conversation

DSchau
Copy link
Contributor

@DSchau DSchau commented Mar 7, 2020

Description

Simple blog post about the recent JS Party + Gatsby podcast. I may flesh this out a bit more, but it's a good start.

</a>{" "}
– Listen on <a href="https://changelog.com/">Changelog.com</a>
</p>
<script async src="//cdn.changelog.com/embed.js"></script>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We honestly may not have a good pattern for this w/ MDX, we may need a custom component.

DSchau added 2 commits March 6, 2020 20:55
Note: this was the only way I could get this working, I wanted to
import, but was getting weird errors with "hooks warnings."
@DSchau DSchau marked this pull request as ready for review March 9, 2020 18:03
@DSchau DSchau requested review from a team as code owners March 9, 2020 18:03
@DSchau
Copy link
Contributor Author

DSchau commented Mar 9, 2020

Done -- I added a global shortcode here for a "ScriptLoader" component to load the JS for the JSParty podcast, which will slightly increase the bundlesize, but seems worth doing.

@DSchau
Copy link
Contributor Author

DSchau commented Mar 9, 2020

There's some weirdness with npm registry / validation of starters. None of those failure should be related to my changes.

Copy link
Contributor

@hashimwarren hashimwarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Widget plays, links work, no typos - looks good! Added one comma for clarity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants