Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby-core-utils): tests url to TS #22046

Closed
wants to merge 1 commit into from
Closed

chore(gatsby-core-utils): tests url to TS #22046

wants to merge 1 commit into from

Conversation

danielkov
Copy link
Contributor

Collection ticket for these tasks: #22041
☂ ticket: #21995

@danielkov danielkov requested a review from a team as a code owner March 8, 2020 00:04
@MichaelDeBoey
Copy link
Contributor

You should do this in #22056, not in a separate PR

@danielkov
Copy link
Contributor Author

@MichaelDeBoey
I literally only separated these into different PRs, because:

Could you please create separate PRs for each file you change, like requested by @blainekasten in #21995 (comment)?

Should I add all files in the same PR or separate? I've done it both ways now. Am I missing something?

@MichaelDeBoey
Copy link
Contributor

@danielkov You should look at the files-list in the umbrella issue.
For each file you see there, you should create a separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielkov @MichaelDeBoey