Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby-core-utils): path to ts #22054

Merged
merged 3 commits into from
Mar 9, 2020
Merged

chore(gatsby-core-utils): path to ts #22054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4144c6c
chore(gatsby-core-utils): tests path to TS
danielkov Mar 8, 2020
cc89d47
chore(gatsby-core-utils): path to ts
danielkov Mar 8, 2020
6be1828
Merge branch 'chore/tests-path-ts' into chore/path-ts
danielkov Mar 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...s/gatsby-core-utils/src/__tests__/path.js → ...s/gatsby-core-utils/src/__tests__/path.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const { joinPath, isNodeInternalModulePath, slash } = require(`../path`)
const os = require(`os`)
import { joinPath, isNodeInternalModulePath, slash } from "../path"
import os from "os"

describe(`paths`, () => {
describe(`joinPath`, () => {
Expand Down
10 changes: 5 additions & 5 deletions packages/gatsby-core-utils/src/path.js → packages/gatsby-core-utils/src/path.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
const path = require(`path`)
const os = require(`os`)
import path from "path"
import os from "os"

/**
* @type {import('../index').joinPath}
*/
export function joinPath(...paths) {
export function joinPath(...paths: string[]): string {
const joinedPath = path.join(...paths)
if (os.platform() === `win32`) {
return joinedPath.replace(/\\/g, `\\\\`)
Expand Down Expand Up @@ -72,7 +72,7 @@ const nodePaths = [
/**
* @type {import('../index').isNodeInternalModulePath}
*/
export const isNodeInternalModulePath = fileName =>
export const isNodeInternalModulePath = (fileName: string): boolean =>
nodePaths.some(regTest => regTest.test(fileName))

/**
Expand All @@ -84,7 +84,7 @@ export const isNodeInternalModulePath = fileName =>
* @param {String} path
* @return {String} slashed path
*/
export function slash(path) {
export function slash(path: string): string {
const isExtendedLengthPath = /^\\\\\?\\/.test(path)

if (isExtendedLengthPath) {
Expand Down