-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gatsby-cli): Convert init-starter to typescript #22086
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thank you so much!
@mottox2 lint is failing:
|
Sorry, I fixed it. Thank you for reviewing. |
Co-Authored-By: Michaël De Boey <info@michaeldeboey.be>
Co-Authored-By: Michaël De Boey <info@michaeldeboey.be>
const spawnWithArgs = ( | ||
file: string, | ||
args: string[], | ||
options?: any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to type this? seems like it should be available maybe on execa
or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to merge because this is the only concern i see, but would love to see this get fixed in a follow up!
Description
Convert
init-starter
to typescriptRelated Issues
Related to #21995