chore(gatsby): Migrate utils/get-public-path.js to ts #22093
Conversation
There was a problem hiding this comment.
This looks great, but since we are changing the export signature there are a handful of files that will need to have their require statement updated. Do a grok of the codebase for require(get-public-path) and you'll find a bunch of references that now need to destructure the named export
| if (prefixPaths && (assetPrefix || pathPrefix)) { | ||
| const normalized = [assetPrefix, pathPrefix] | ||
| .filter(part => part && part.length > 0) | ||
| .filter((part): part is string => (part ? part.length > 0 : false)) |
There was a problem hiding this comment.
part is string is this valid syntax? Why not just part: string I think this line is wrong. I think you want (part: string): boolean => ..
There was a problem hiding this comment.
part is string is valid syntax called type predicate officially. As far as I know, TS cannot infer types exactly inside Array.prototype.reduce() so if it is (part: string): boolean => .. the compiler infers part in the next map as string | undefined
example
Sorry I missed it. I will fix that right away. |
blainekasten
added
the
bot: merge on green
Description
Convert
utils/get-public-pathto typescriptDocumentation
Related Issues
Related to #21995