fix(gatsby): Update types for WrapPageElement*Args

[adambrgmn]

Description

Hi, and thanks for a great project! This (my first) PR is just a small thing proposing an update to the typescript types. It should possibly be opened as an issue first, but since the changes are so small I thought it would be easiest to make it a PR directly – a PR which of course can be closed if I've misunderstood anything.

I propose updated types for the interfaces WrapPageElementBrowserArgs and WrapPageElementNodeArgs with a more detailed props definition. PR #21542 introduced a new detailed interface for page props and I figured this interface can also be used for the types for wrapPageElement.

I could of course be wrong (the docs and the current interface only specify props as a vague object) but my guess is that props in wrapPageElement is the same props passed to pages. Please correct me if I'm wrong.

Documentation

The arguments passed to wrapPageElement are documented in two places – browser and ssr. Would you like me to touch on these as well?

Related Issues

No related issues found.

[pieh]

This is mostly correct, but there are few differences between SSR and Browser - mainly in SSR we don't have pageResources object that is there in browser (but this is not in scope of this PR).

Let's get this in.

I feel like there would need to be some restructure to GatsbyBrowser interface, because those generic templates will need to be used manually for now, but we can work on that incrementally.

[gatsbot]

Holy buckets, @adambrgmn — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

[adambrgmn]

@pieh thanks! I might take a stab at it since I share your "concerns"!

How often does a release happen (read; when will this be published)? 😬

[pieh]

We release couple times a day, I will release soon and let you know ;)

[pieh]

Published gatsby@2.19.35