Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby) Convert get-value-at to typescript #22182

Merged

Conversation

martijnjanssen
Copy link
Contributor

Description

Convert utils/get-value-at and __tests__/get-value-at to Typescript

Related Issues

Related to #21995

@martijnjanssen martijnjanssen requested a review from a team as a code owner March 11, 2020 15:35
@martijnjanssen martijnjanssen changed the title chore(gatsby) get value at chore(gatsby) Convert get-value-at to typescript Mar 11, 2020
@martijnjanssen martijnjanssen force-pushed the chore/typescript-get-value-at branch from ca35e50 to 4a56985 Compare March 11, 2020 15:40
@blainekasten blainekasten added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: TypeScript migration labels Mar 11, 2020
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, let's merge it!

Thank you so much for contributing to our TypeScript refactor! We have more work to do and we would love to have you stay involved in our transition. Please submit more PRs! 💜

@gatsbybot gatsbybot merged commit b8862be into gatsbyjs:master Mar 11, 2020
@gatsbot
Copy link

gatsbot bot commented Mar 11, 2020

Holy buckets, @martijnjanssen — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@martijnjanssen martijnjanssen deleted the chore/typescript-get-value-at branch March 11, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants