Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby): migrate test-require-error to typescript #22265

Merged
merged 4 commits into from
Mar 19, 2020
Merged

chore(gatsby): migrate test-require-error to typescript #22265

merged 4 commits into from
Mar 19, 2020
+6 −5

Conversation

sasurau4
Copy link
Contributor

Description

Part of #21995
I migrate test-require-error.js to TypeScript

Documentation

Related Issues

related to #21995

@sasurau4 sasurau4 requested a review from a team as a code owner March 14, 2020 09:05
@blainekasten blainekasten mentioned this pull request Mar 14, 2020
Closed
@blainekasten blainekasten added the status: awaiting author response Additional information has been requested from the author label Mar 19, 2020
@sasurau4 sasurau4 requested a review from blainekasten March 19, 2020 12:50
blainekasten
blainekasten approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, let's merge it!

Thank you so much for contributing to our TypeScript refactor! We have more work to do and we would love to have you stay involved in our transition. Please submit more PRs! 💜

@blainekasten blainekasten added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed status: awaiting author response Additional information has been requested from the author labels Mar 19, 2020
@gatsbybot gatsbybot merged commit 0700cd5 into gatsbyjs:master Mar 19, 2020
@sasurau4 sasurau4 deleted the migrate/test-require-error-to-ts branch March 19, 2020 15:24
This was referenced Aug 5, 2021
Open
Open
@snyk-bot snyk-bot mentioned this pull request Aug 13, 2021
Open
This was referenced Mar 22, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blainekasten blainekasten blainekasten approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sasurau4 @blainekasten @danabrit @gatsbybot