Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby): Convert utils/tracer/index to typescript #22296

Merged
merged 2 commits into from
Mar 17, 2020
Merged

chore(gatsby): Convert utils/tracer/index to typescript #22296

merged 2 commits into from
Mar 17, 2020

Conversation

kawamataryo
Copy link
Contributor

@kawamataryo kawamataryo commented Mar 15, 2020 •
edited
Loading

Description

Convert utils/tracer/index to typescript.

Related Issues

Related to #21995

@kawamataryo kawamataryo requested a review from a team as a code owner March 15, 2020 11:48
@blainekasten blainekasten mentioned this pull request Mar 15, 2020
Closed
@kawamataryo kawamataryo changed the title chore(gatsby): Convert util/utils/tracer/index to typescript chore(gatsby): Convert utils/tracer/index to typescript Mar 15, 2020
blainekasten
blainekasten previously approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, let's merge it! (once you get tests to pass)

Thank you so much for contributing to our TypeScript refactor! We have more work to do and we would love to have you stay involved in our transition. Please submit more PRs! 💜

@pieh pieh removed the status: WIP label Mar 17, 2020
pieh
pieh approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pieh pieh merged commit c3eccce into gatsbyjs:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

@blainekasten blainekasten blainekasten left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kawamataryo @pieh @blainekasten