-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-source-medium): define types explicitly via createSchemaCustomization (#20069) #22377
feat(gatsby-source-medium): define types explicitly via createSchemaCustomization (#20069) #22377
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! 🎉
One problem is that Medium seems to have several fields that are available conditionally. I took official gatsby medium example and compared schema produced for it against the schema from this PR - and there are some differences. See the diff.
So I suggest the following changes:
- Remove
@dontInfer
directive for now because it may lead to breaking changes. We will probably add it to the next major version of this plugin. - Remove
@derivedTypes
directive - as it is unnecessary. - Add fields from the diff above to this PR (that gist contains both schema files if you need to make diffs locally).
- Make all types uppercase (not sure why some of them are lowercased)?
Please let me know what you think and thanks a lot for the PR! It helps our schema customization initiative a lot!
Awesome, thanks for update! I will try it locally (hopefully tomorrow) and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Let's ship it 🚢
And thank you for your interest in helping us with schema customization!
Holy buckets, @Powell-v2 — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Description
Use createSchemaCustomization for explicit type declarations in
gatsby-source-medium
plugin.Related Issues
Umbrella issue => #20069