Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused variable and wrong propTypes #22426

Merged
merged 3 commits into from
Mar 20, 2020
Merged

Conversation

soobing
Copy link
Contributor

@soobing soobing commented Mar 20, 2020

Description

Documentation

seo and social sharing cards tutorial

Related Issues

closes #22425

@soobing
Copy link
Contributor Author

soobing commented Mar 20, 2020

Fail from ci/circleci: lint — Your tests failed on CircleCI is not from this issue. Build on master is failing because of a lint conflict. Please check.

Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, makes sense, thanks!

@pieh pieh added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Mar 20, 2020
@gatsbybot gatsbybot merged commit cfc6413 into gatsbyjs:master Mar 20, 2020
@gatsbot
Copy link

gatsbot bot commented Mar 20, 2020

Holy buckets, @soobing — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SEO and Social sharing cards tutorial - Unused variable and wrong propTypes
3 participants