chore(gatsby): migrate date to TypeScript #22430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the late response on this. Can you please rebase onto master? Thanks! |
sasurau4
force-pushed
the
migrate/type-of-date-to-typescript
branch
from
62a05a6 to
b5eaf03
Compare
sasurau4
commented
Jun 5, 2020
pvdz
suggested changes
Jun 30, 2020
There was a problem hiding this comment.
Hey. I'm sorry this has been untouched in a while. I think it looks good and just needs a few unrelated changes to be dropped to be merged. Do you want to proceed with that? Cheers!
I can try to run the format and rebase bot and see how that ends up. Formatting fine now, Please just drop that added require line and to move the type definitions up :)
sasurau4
force-pushed
the
migrate/type-of-date-to-typescript
branch
from
98fd3c2 to
0221560
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #21995
I migrated
types/date.jsto typescript.Documentation
Related Issues
#21995