Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(www/dark-mode-toggle): title and aria-label[object Object] issue #22473

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

armujahid
Copy link
Contributor

Description

This fixes incorrect title and aria-label issue of dark mode toggle button
image

Related: #21633

Note that I haven't tested this fix locally yet because gatsby develop in www is taking too much time on my PC.

@armujahid armujahid requested a review from a team as a code owner March 21, 2020 20:45
@armujahid
Copy link
Contributor Author

I have tested this and it's working fine.

Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@LekoArts LekoArts merged commit a7b7e48 into gatsbyjs:master Mar 23, 2020
@gatsbot
Copy link

gatsbot bot commented Mar 23, 2020

Holy buckets, @armujahid — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@armujahid armujahid deleted the www-dark-mode-toggle branch March 23, 2020 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants