Gatsby cli develop tests #22697
Merged
Gatsby cli develop tests #22697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madalynrose
reviewed
Mar 31, 2020
|
|
||
| beforeAll(() => removeFolder(`${cwd}/.cache`)) | ||
| beforeAll(() => removeFolder(`${cwd}/public`)) | ||
| afterAll(() => removeFolder(`${cwd}/.cache`)) |
There was a problem hiding this comment.
why do we need this both before and after?
There was a problem hiding this comment.
do it before just to make sure there wasn't some left over artifacts before. Like if some dev ran gatsby build or something in taht folder before the test. Then also clean up after.
Just trying to make the tests as idempotent as possible.
madalynrose
added
the
bot: merge on green
madalynrose
approved these changes
Mar 31, 2020
teleaziz
added a commit
to teleaziz/gatsby
that referenced
this pull request
Apr 2, 2020
…y-starter-builder * 'master' of github.com:gatsbyjs/gatsby: (24 commits) Added Fluiditype (gatsbyjs#22686) Add blog post with Gatsby LA video 2 - Dustin Schau (gatsbyjs#22736) Fix DatoCMS benchmarks (gatsbyjs#22761) chore(starters): add gatsby-starter-reason-blog (gatsbyjs#22690) remove local domain (gatsbyjs#22729) remove local domain (gatsbyjs#22732) fix(gatsby-source-contentful): use request url for base64 image cache key (gatsbyjs#22745) Add blog post for community Q&A (gatsbyjs#22737) chore(gatsby-cli): use `gatsby clean` in tests to test `gatsby clean` (gatsbyjs#22739) Fix typo (gatsbyjs#22727) fix(gatsby): Support grouping by reserved keywords (gatsbyjs#22603) remove local domain (gatsbyjs#22723) docs: clarification about `.cache` and `public` persistance when using GATSBY_EXPERIMENTAL_PAGE_BUILD_ON_DATA_CHANGES (gatsbyjs#22720) chore(release): Publish fix(gatsby-plugin-google-gtag): OutboundLink Forward Ref (gatsbyjs#22705) [docs]Docs/Blog Frontmatter Documentation (gatsbyjs#22604) chore(gatsby): create single filter cache key generator (gatsbyjs#22716) chore(gatsby-cli): Add integration tests for `gatsby develop` (gatsbyjs#22699) create index.md (gatsbyjs#22671) Gatsby cli develop tests (gatsbyjs#22697) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Integration tests for
gatsby develop