Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-styletron): Styletron to peerDependencies #22731

Merged
merged 3 commits into from
May 6, 2020
Merged

fix(gatsby-plugin-styletron): Styletron to peerDependencies #22731

merged 3 commits into from
May 6, 2020

Conversation

nadiia
Copy link
Contributor

@nadiia nadiia commented Apr 1, 2020 •
edited
Loading

Description

Move styletron-react and styletron-engine-atomic to peerDependencies in gatsby-plugin-styletron.

Documentation

@nadiia nadiia requested review from a team as code owners April 1, 2020 19:56
@nadiia nadiia force-pushed the plugin-styletron-dep branch from 1330d5c to dccfb5a Compare April 1, 2020 19:58
@vladar
Copy link
Contributor

vladar commented Apr 9, 2020

Can you explain the problem you have? We typically encourage everyone to open an issue before the PR so that there was enough context on the problem.

@nadiia
Copy link
Contributor Author

nadiia commented Apr 10, 2020 •
edited
Loading

We don't want projects to end up with more than one Styletron version or not be able to upgrade as Styletron is plugin's dependency vs peer.

@wardpeet wardpeet added the breaking change If implemented, this proposed work would break functionality for older versions of Gatsby label Apr 10, 2020
wardpeet
wardpeet reviewed Apr 10, 2020
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nadiia

Thanks, peer-deps make sense here. I slapped the breaking-change label on there so we don't forget to push a major out.

If you clear your package-lock.json or yarn.lock you probably end up with only 1 version.

@wardpeet wardpeet changed the title fix(gatsby-plugin-styletron): move Styletron to peerDependencies fix(gatsby-plugin-styletron): Styletron to peerDependencies May 6, 2020
@wardpeet wardpeet merged commit a4969d9 into gatsbyjs:master May 6, 2020
@wardpeet
Copy link
Contributor

wardpeet commented May 6, 2020

Successfully published in gatsby-plugin-styletron@5.0.0

@wardpeet
Copy link
Contributor

wardpeet commented May 6, 2020

Thank you for your PR! And sorry to keep you waiting to get this resolved.

This was referenced Sep 24, 2020
Open
Open
This was referenced Sep 1, 2021
Open
Open
This was referenced Jan 18, 2022
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Jun 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet left review comments

Assignees
No one assigned
Labels
breaking change If implemented, this proposed work would break functionality for older versions of Gatsby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nadiia @vladar @wardpeet