Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(starters): Upgrade react-helmet in default starter #23059

Merged
merged 1 commit into from
Apr 16, 2020
Merged

fix(starters): Upgrade react-helmet in default starter #23059

merged 1 commit into from
Apr 16, 2020

Conversation

karlhorky
Copy link
Contributor

@karlhorky karlhorky commented Apr 13, 2020

Description

Remove warning caused by pre-v6 react-helmet in default starter (see #17865)

Documentation

#17865

Related Issues

Closes #17865

cc @lannonbr

@karlhorky
Copy link
Contributor Author

Hm, not sure what's erroring on CI... The only thing that I can see scanning that huge long log is the failing npm audit at the bottom (minimist vulnerability)?

Screen Shot 2020-04-13 at 17 29 14

And apparently I can't access build-test:

Screen Shot 2020-04-13 at 17 27 47

Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@vladar vladar changed the title Upgrade react-helmet in default starter fix(starters): Upgrade react-helmet in default starter Apr 16, 2020
@vladar vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Apr 16, 2020
@gatsbybot gatsbybot merged commit 1700ddb into gatsbyjs:master Apr 16, 2020
@karlhorky karlhorky deleted the update-react-helmet-in-default-starter branch April 16, 2020 10:50
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested dependency calling soon to be deprecated componentWillMount method
3 participants