Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby-preset-gatsby-package): Remove tsconfig.json #23388

Merged

Conversation

blainekasten
Copy link
Contributor

Description

We closed #22039 realizing that package doesn't benefit from conversion. This removes the tsconfig.json, meaning we don't check it with tsc anymore.

@blainekasten blainekasten requested a review from a team as a code owner April 22, 2020 19:59
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blainekasten blainekasten merged commit 99f8000 into master Apr 23, 2020
@blainekasten blainekasten deleted the remove-preset-package-from-typescript-conversion branch April 23, 2020 02:09
pvhee added a commit to marzeelabs/gatsby that referenced this pull request Apr 24, 2020
* 'master' of github.com:gatsbyjs/gatsby: (64 commits)
  Fix recipe test problems (gatsbyjs#23347)
  create blog post announcing extended deadline for Virtual Gatsby Days… (gatsbyjs#23430)
  Correct CFP deadline date on Virtual Gatsby Days registration announcement (gatsbyjs#23432)
  fix(gatsby-recipes): Raise an error when an unknown resource is used (gatsbyjs#23428)
  feat(gatsby-recipes): While apply a step, show the time elapsed after 10 seconds (gatsbyjs#23362)
  markdownASTToHTMLAst isn't async (gatsbyjs#23427)
  Be more vocal about not doing type checking (gatsbyjs#23397)
  docs(gatsby-remark-images): mark `sizeByPixelDensity` as deprecated (gatsbyjs#23387)
  chore(all): Improve renovate (gatsbyjs#23411)
  chore(gatsby): count sift hits in telemetry (gatsbyjs#23416)
  chore(showcase): add GeneOS and COVID KPI (gatsbyjs#23405)
  feat(analytics): defer google analytics script (gatsbyjs#22806)
  docs: mention passing the .tsx file to createPage (gatsbyjs#23329)
  fix(www): tweak docsearch to init algolia when tabbed into (gatsbyjs#23040)
  chore(docs): Fix typo in url (gatsbyjs#23394)
  chore(gatsby-preset-gatsby-package): Remove tsconfig.json (gatsbyjs#23388)
  fix(gatsby-recipes): link to the raw gist of .estlintrc.js (gatsbyjs#23390)
  docs: Create gitlab-continuous-integration.md (gatsbyjs#23367)
  chore(doc): switch zeit now to Vercel Now for Gatsby deployment (gatsbyjs#23346)
  chore(showcase): add Resume on the Web (gatsbyjs#23371)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants