Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): Migrate build-example-data to TS #23389

Merged
merged 2 commits into from
Apr 24, 2020

Conversation

chooban
Copy link
Contributor

@chooban chooban commented Apr 22, 2020

Description

Migrated schema/infer/build-example-data to TypeScript. As with a previous PR (#23264), I've switched off the complaints about using a function before defining it in order to help with the diff.

Related Issues

ref #21995

@vladar vladar self-assigned this Apr 23, 2020
@vladar vladar added the topic: GraphQL Related to Gatsby's GraphQL layer label Apr 23, 2020
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the help with TS migration! 💜

@vladar vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Apr 24, 2020
@gatsbybot gatsbybot merged commit d847855 into gatsbyjs:master Apr 24, 2020
@chooban
Copy link
Contributor Author

chooban commented Apr 24, 2020

You're welcome! This is super useful to me as I'm doing more TypeScript at the moment and having to work out an existing codebase is a really helpful exercise.

@chooban chooban deleted the ts-migrate/build-example-data branch April 24, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: GraphQL Related to Gatsby's GraphQL layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants