Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert remove-stale-job to TS #23538

Merged
merged 3 commits into from
Apr 29, 2020
Merged

Convert remove-stale-job to TS #23538

merged 3 commits into from
Apr 29, 2020

Conversation

gabrieluizramos
Copy link
Contributor

@gabrieluizramos gabrieluizramos commented Apr 27, 2020 •
edited
Loading

Description

Converts packages/gatsby/src/bootstrap/remove-stale-job to TS.

Related Issues

Related to #21995

@gabrieluizramos gabrieluizramos requested a review from a team as a code owner April 27, 2020 19:27
@gabrieluizramos gabrieluizramos requested a review from a team as a code owner April 27, 2020 19:59
blainekasten
blainekasten approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, let's merge it!

Thank you so much for contributing to our TypeScript refactor! We have more work to do and we would love to have you stay involved in our transition. Please submit more PRs! 💜

@blainekasten blainekasten added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Apr 29, 2020
@gatsbybot gatsbybot merged commit b35c398 into gatsbyjs:master Apr 29, 2020
@gatsbot
Copy link

gatsbot bot commented Apr 29, 2020

Holy buckets, @gabrieluizramos — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@blainekasten blainekasten mentioned this pull request Apr 29, 2020
Closed
@gabrieluizramos
Copy link
Contributor Author

Thank you very much @blainekasten !

I'm really glad to be part of this ride! Let's keep the awesome work! 🚀

@gabrieluizramos gabrieluizramos deleted the ts/remove-stale-jobs branch April 29, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blainekasten blainekasten blainekasten approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabrieluizramos @blainekasten @LekoArts @gatsbybot