Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert api-browser and api-node docs to TS #23688

Merged
merged 2 commits into from
May 6, 2020

Conversation

gabrieluizramos
Copy link
Contributor

Description

In order to continue the conversion, this PR converts api-browser-docs and api-node-docs to TS.

Related Issues

Related to #21995

@gabrieluizramos gabrieluizramos requested review from a team as code owners May 1, 2020 21:55
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 1, 2020
@TylerBarnes TylerBarnes added status: inkteam assigned and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 1, 2020
@gabrieluizramos gabrieluizramos force-pushed the ts/api-browser-and-node-docs branch from e73f6f6 to 9ba3eb1 Compare May 2, 2020 03:32
@gabrieluizramos
Copy link
Contributor Author

@blainekasten Hi Blaine! Can you help me with this one? All the tests are passing locally but there's one check with error that I can't access...

packages/gatsby/src/utils/api-node-docs.ts Outdated Show resolved Hide resolved
@gabrieluizramos gabrieluizramos force-pushed the ts/api-browser-and-node-docs branch from 06bf31a to 1dcbde4 Compare May 6, 2020 12:47
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, let's merge it!

Thank you so much for contributing to our TypeScript refactor! We have more work to do and we would love to have you stay involved in our transition. Please submit more PRs! 💜

@blainekasten blainekasten merged commit 7888560 into master May 6, 2020
@blainekasten blainekasten deleted the ts/api-browser-and-node-docs branch May 6, 2020 13:49
@dja
Copy link

dja commented May 6, 2020

It looks like the production page for the Gatsby Browser APIs is now blank. Is it related to this?

@gabrieluizramos
Copy link
Contributor Author

gabrieluizramos commented May 6, 2020

@dja I'm not sure, but I've already opened the revert so we can test it: #23853

Could you check it, please?

@ascorbic
Copy link
Contributor

ascorbic commented May 7, 2020

I have a fix for the API docs #23863

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants