Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby): migrate merge-gatsby-config to TypeScript #23789

Merged
merged 7 commits into from
May 19, 2020
Merged

chore(gatsby): migrate merge-gatsby-config to TypeScript #23789

merged 7 commits into from
May 19, 2020

Conversation

taejs
Copy link
Contributor

@taejs taejs commented May 5, 2020

Description

migrate merge-gatsby-config to TypeScript

Related Issues

Related to #21995

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 5, 2020
@taejs taejs force-pushed the ts-migration/merge-gatsby-config branch from f4adee8 to 93dc7fe Compare May 5, 2020 14:52
@blainekasten blainekasten mentioned this pull request May 5, 2020
Closed
@pieh pieh added type: TypeScript migration and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 5, 2020
@taejs taejs marked this pull request as ready for review May 6, 2020 07:13
@taejs taejs requested review from a team as code owners May 6, 2020 07:13
@pieh pieh mentioned this pull request May 6, 2020
Merged
@pieh
Copy link
Contributor

pieh commented May 6, 2020

I would also like to wait with merging this PR to land #23696 first (it will be easier for me to adjust this PR after previous one that the other way around I think

@taejs taejs force-pushed the ts-migration/merge-gatsby-config branch from 93dc7fe to 865d636 Compare May 12, 2020 10:31
@pieh pieh self-assigned this May 12, 2020
@taejs taejs closed this May 12, 2020
@taejs taejs force-pushed the ts-migration/merge-gatsby-config branch from 865d636 to 885e3e4 Compare May 12, 2020 11:03
@taejs taejs reopened this May 12, 2020
@taejs taejs force-pushed the ts-migration/merge-gatsby-config branch from 0fb8224 to eb09da2 Compare May 12, 2020 11:16
@taejs taejs requested a review from pieh May 12, 2020 12:58
pieh
pieh requested changes May 12, 2020
View reviewed changes
packages/gatsby/src/utils/merge-gatsby-config.ts Outdated Show resolved Hide resolved
packages/gatsby/src/utils/merge-gatsby-config.ts Outdated Show resolved Hide resolved
packages/gatsby/src/utils/merge-gatsby-config.ts Outdated Show resolved Hide resolved
packages/gatsby/src/utils/merge-gatsby-config.ts Outdated Show resolved Hide resolved
@taejs taejs force-pushed the ts-migration/merge-gatsby-config branch from c5ad22e to 584c247 Compare May 18, 2020 04:13
@taejs taejs requested a review from pieh May 18, 2020 13:17
@taejs taejs requested review from a team as code owners May 19, 2020 09:59
@pieh
Copy link
Contributor

pieh commented May 19, 2020

ops, messed stuff up (will fix)

@pieh pieh force-pushed the ts-migration/merge-gatsby-config branch from 6b064a0 to 486a656 Compare May 19, 2020 10:19
pieh
pieh approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @taejs! Sorry about back and forth about IGatsbyConfig earlier, that wasn't thought through initially

@pieh pieh merged commit 2c38a9d into gatsbyjs:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees

@pieh pieh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taejs @pieh