Update json logger in gatsby-cli to TS #24140
Conversation
gatsbot
bot
added
the
status: triage needed
| const sanitizedAction = sanitizeAction(action) | ||
|
|
||
| process.stdout.write(JSON.stringify(sanitizedAction) + `\n`) | ||
| }) |
There was a problem hiding this comment.
We actually want to change this module to not invoke functionality on import. So this onLogAction should be wrapped in an exported function, which should then be executed in the parent module. Mind making these changes?
export function initializeJSONLogger() {
onLogAction(....)
}
There was a problem hiding this comment.
I've changed this to named export initializeJSONLogger
| import stripAnsi from "strip-ansi" | ||
| import _ from "lodash" | ||
|
|
||
| const isStringPayload = (action: ActionsUnion): action is ISetStatus => |
There was a problem hiding this comment.
can we get away without this action is ISetStatus ?
There was a problem hiding this comment.
I use action is ISetStatus to filter out ISetStatus which payload is a string.
| action.payload.statusText = stripAnsi(action.payload.statusText) | ||
| } | ||
|
|
||
| return action |
There was a problem hiding this comment.
I think there is a functional change going on here. In the previous version, we were creating a new object and spreading values into it. This had the benefit that we weren't mutating the underlying object.
I think there is a risk here that this function in it's new state would actually be modifying values that are in redux state (thanks JS object referencing.)
Let's change this to create a new object instead of modifying the one passed in.
There was a problem hiding this comment.
Now I use guideline from IPC to copy new object before stripAnsi.
blainekasten
added
status: awaiting author response
blainekasten
added
bot: merge on green
Description
This PR migrates
gatsby-cli/src/reporter/loggers/json/index.jsto TypeScript.Related Issues
Part of #21995.