Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby-cli): Convert errors and prepare-stack-trace to TypeScript #24226

Merged
merged 7 commits into from
May 19, 2020

Conversation

blainekasten
Copy link
Contributor

Description

Migrates reporter/errors and reporter/prepare-stack-trace to TypeScript!

Along the way made a few improvements to the code. Will document with inline comments!

Related Issues

Related to #21995

@blainekasten blainekasten requested a review from a team as a code owner May 19, 2020 15:54
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 19, 2020
@blainekasten blainekasten force-pushed the ts-conversion/cli-errors-and-stack-trace branch from 1de551d to 2b3947c Compare May 19, 2020 15:56
@blainekasten blainekasten force-pushed the ts-conversion/cli-errors-and-stack-trace branch from f7156cd to d3517c5 Compare May 19, 2020 16:04
@pieh pieh added type: TypeScript migration and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 19, 2020
@pieh pieh self-assigned this May 19, 2020
pieh
pieh previously approved these changes May 19, 2020
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for converting this stuff that noone else dared to touch ;)

@blainekasten blainekasten merged commit bcf7214 into master May 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the ts-conversion/cli-errors-and-stack-trace branch May 19, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants