chore(gatsby) Rewrite requires-writer.js to TypeScript #24289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Mostly just adds TypeScript type annotations - Introduces one assertion for matchPath !== undefined as IGatsbyPage has it as string | undefined, but everything in requires-writer.js assumes that it's a string. It would throw an error anyway, I just made a bit more pretty with reporter.panic() WARNING: - requires-writer uses reporter from gatsby-cli, and not the TS source, but the compiled version. Not sure if it's ok. Maybe we should extract reporter into a separate package if it is used in both gatsby and gasby-cli
gatsbot
bot
added
the
status: triage needed
freiksenet
removed
the
status: triage needed
blainekasten
approved these changes
May 26, 2020
This was the perfect thing to do :)
I agree with this, it's been something on our mind. We'll get there eventually :D Thanks for the awesome PR! |
johno
pushed a commit
to johno/gatsby
that referenced
this pull request
May 28, 2020
- Mostly just adds TypeScript type annotations - Introduces one assertion for matchPath !== undefined as IGatsbyPage has it as string | undefined, but everything in requires-writer.js assumes that it's a string. It would throw an error anyway, I just made a bit more pretty with reporter.panic() WARNING: - requires-writer uses reporter from gatsby-cli, and not the TS source, but the compiled version. Not sure if it's ok. Maybe we should extract reporter into a separate package if it is used in both gatsby and gasby-cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds type annotations to
requires-writer.jsfrom thegatsbypackageI had to introduce one assertion for
matchPath !== undefinedasIGatsbyPageit's of typestring | undefined, but everything inrequires-writer.jsassumes that it's astring. It would throw an error anyway, I just made a bit more pretty withreporter.panic()NOTE:
requires-writer.jsuses the reporter fromgatsby-cli, and not the TS source, but the compiled version. Not sure if it's ok. Maybe we should extract reporter into a separate package if it is used in bothgatsbyandgasby-cliDocumentation
No changes required
Related Issues
Related to #21995