Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(doc):Add guide to Deploy Gatsby to DigitalOcean droplet. #24652
chore(doc):Add guide to Deploy Gatsby to DigitalOcean droplet. #24652
Changes from 8 commits
8fcadf5
0719d24
ae5f680
2c861e1
71c6c35
f8db030
9229f7d
c19c237
2867e71
1e5b7aa
5a8b787
81669d6
d0477fa
788d42b
ed4178d
d213d4a
6c3bd8f
a150446
463f41b
135f281
67220f6
4cb6cc9
2fb05d6
b5ebacc
e911332
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems quite cumbersome to have to log back in to run a manual build. Is there a more automated way of picking up changes that we could recommend?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could achieve CI or automated builds with the use of Github Actions and Git hooks? But don't you think it would make this guide more of a tutorial? We could keep the guide pretty raw and basic, we can obviously make a tutorial on building CI for this deployment option and link it to this guide. What are your views?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there. I think at least mentioning it would be useful–even a link to an offsite resource for automating builds. I don't think that would tip a guide toward a tutorial, as this is already pretty sequential even with standalone headings as opposed to "steps". But we could get this one merged and open that as a separate issue, perhaps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I have searched for some good off-site resources, but I don't find any good resource to add as a link in this doc. Those resources are not exact to what we need. I think adding them, would mislead people. Instead, I'm planning to write a micro-tutorial on building automated CI for Gatsby and Digitalocean on some off-site platform which we can add as a link to this doc later on. Or else, as you suggested we can open this as a separate issue to write a tutorial. Let me know what do you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think opening a separate issue to follow this PR is a good idea, that way we can track it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Perfect! 😃