Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(gatsby): Query Filters #24775

Merged
merged 3 commits into from
Aug 11, 2020
Merged

docs(gatsby): Query Filters #24775

merged 3 commits into from
Aug 11, 2020

Conversation

pvdz
Copy link
Contributor

@pvdz pvdz commented Jun 4, 2020

Create new documentation for filters in GraphQL queries in Gatsby.

@pvdz pvdz requested a review from a team as a code owner June 4, 2020 12:49
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 4, 2020
@pvdz pvdz requested review from freiksenet and vladar June 4, 2020 12:50
@pvdz pvdz marked this pull request as draft June 4, 2020 12:55
@pvdz pvdz force-pushed the docs-filters branch 4 times, most recently from 8d54ed4 to fcda70d Compare June 4, 2020 13:51
@pvdz pvdz marked this pull request as ready for review June 4, 2020 13:52
@pvdz pvdz added status: needs core review Currently awaiting review from Core team member status: needs dx review status: needs docs review Pull request related to documentation waiting for review type: documentation An issue or pull request for improving or updating Gatsby's documentation topic: GraphQL Related to Gatsby's GraphQL layer and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 4, 2020
marcysutton
marcysutton previously requested changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@marcysutton marcysutton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interesting info! This looks really good to me, though it needs to be added to the doc-links sidebar. I'd recommend listing it under Conceptual Guide or Gatsby Internals, since it's a bit more in-depth than a typical Reference Guide. Let me know what you think.

Sidebars: https://github.com/gatsbyjs/gatsby/tree/master/www/src/data/sidebars
Breadcrumb info: http://localhost:8000/contributing/docs-contributions/#configuring-site-navigation

docs/docs/query-filters.md Show resolved Hide resolved
docs/docs/query-filters.md Outdated Show resolved Hide resolved
docs/docs/query-filters.md Outdated Show resolved Hide resolved
docs/docs/query-filters.md Outdated Show resolved Hide resolved
docs/docs/query-filters.md Outdated Show resolved Hide resolved
docs/docs/query-filters.md Outdated Show resolved Hide resolved
docs/docs/schema-sift.md Outdated Show resolved Hide resolved
freiksenet
freiksenet reviewed Jun 17, 2020
View reviewed changes
docs/docs/query-filters.md Outdated Show resolved Hide resolved
docs/docs/query-filters.md Outdated Show resolved Hide resolved
@pvdz
Copy link
Contributor Author

pvdz commented Jun 18, 2020

Thanks for the review, @marcysutton and @freiksenet :)

I'd recommend listing it under Conceptual Guide or Gatsby Internals, since it's a bit more in-depth than a typical Reference Guide

Good point, I forgot about that. The previous guide, which this replaces, was listed under Gatsby Internals > Schema Generation so I'll replace the old entry with the new.

@pvdz pvdz requested a review from a team as a code owner June 18, 2020 08:49
@laurieontech laurieontech removed the status: needs docs review Pull request related to documentation waiting for review label Jun 19, 2020
@danabrit danabrit added status: needs docs review Pull request related to documentation waiting for review and removed status: needs dx review labels Jul 6, 2020
AishaBlake
AishaBlake previously approved these changes Jul 8, 2020
View reviewed changes
Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up on Marcy's review, this looks great! Thank you so much for pulling this together, @pvdz!

@AishaBlake AishaBlake dismissed marcysutton’s stale review July 8, 2020 18:14

comments addressed

@AishaBlake AishaBlake removed the status: needs docs review Pull request related to documentation waiting for review label Jul 8, 2020
@AishaBlake
Copy link

I'm leaving this alone since it's still marked Needs Core review. @freiksenet, if you're happy with this, I think it can be merged!

@pvdz @freiksenet
Update docs/docs/query-filters.md
7e4897c 
Co-authored-by: Mikhail Novikov <freiksenet@gmail.com>
@pvdz pvdz merged commit 14e9533 into master Aug 11, 2020
@pvdz
Copy link
Contributor Author

pvdz commented Aug 11, 2020

Thank you, @AishaBlake :)

@pvdz pvdz removed the status: needs core review Currently awaiting review from Core team member label Aug 11, 2020
@muescha muescha mentioned this pull request Aug 12, 2020
Merged
@LekoArts LekoArts deleted the docs-filters branch November 9, 2020 08:28
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
@gatsbybot @freiksenet
docs(gatsby): Query Filters (gatsbyjs#24775)
f374a22 
* docs(gatsby): Query Filters

* Applied suggestions

* Update docs/docs/query-filters.md

Co-authored-by: Mikhail Novikov <freiksenet@gmail.com>

Co-authored-by: Mikhail Novikov <freiksenet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muescha muescha muescha left review comments

@freiksenet freiksenet freiksenet left review comments

@AishaBlake AishaBlake AishaBlake left review comments

@marcysutton marcysutton marcysutton left review comments

@vladar vladar Awaiting requested review from vladar

Assignees
No one assigned
Labels
topic: GraphQL Related to Gatsby's GraphQL layer type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pvdz @AishaBlake @freiksenet @muescha @marcysutton @danabrit @laurieontech