Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(examples): skip nave Readme - code blocks, brand names #24826

Merged
merged 1 commit into from
Jun 8, 2020
Merged

fix(examples): skip nave Readme - code blocks, brand names #24826

merged 1 commit into from
Jun 8, 2020

Conversation

muescha
Copy link
Contributor

@muescha muescha commented Jun 5, 2020

Description

changes:

  • add title= to code blocks
  • add file name into code block because title is not visible in readme on github
  • add code fences to function names
  • add code block and mark treeviews with text language
  • fix closing code fences tag
  • fix brand name cypress -> Cypress

Related Issues

@muescha muescha requested a review from a team as a code owner June 5, 2020 20:25
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 5, 2020
gillkyle
gillkyle approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@gillkyle gillkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@gillkyle gillkyle added status: needs docs review Pull request related to documentation waiting for review type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer status: needs docs review Pull request related to documentation waiting for review labels Jun 8, 2020
@gillkyle gillkyle merged commit 7890dae into gatsbyjs:master Jun 8, 2020
@muescha muescha deleted the muescha/fix/reach-skip-nav branch June 8, 2020 15:06
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
@gatsbybot
fix(examples): skip nave Readme - code blocks, brand names (gatsbyjs#…
0a188bc 
…24826)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gillkyle gillkyle gillkyle approved these changes

Assignees
No one assigned
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muescha @gillkyle