refactor(gatsby): convert program reducer to typescript #24941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
tgallacher
changed the title
pvdz
added
topic: TypeScript migration
and removed
status: triage needed
blainekasten
force-pushed
the
ts-migration/program-reducer
branch
from
e0a01af to
2454aed
Compare
blainekasten
previously approved these changes
Jun 16, 2020
blainekasten
added
the
bot: merge on green
blainekasten
previously approved these changes
Jun 16, 2020
blainekasten
approved these changes
Jun 17, 2020
|
Holy buckets, @tgallacher — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
axe312ger
pushed a commit
that referenced
this pull request
Jun 23, 2020
* rename file to .ts ext * refactor(gatsby): conver program reducer to typescript * Update typings approach * update yarn.lock * change to use lib reporter Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
* rename file to .ts ext * refactor(gatsby): conver program reducer to typescript * Update typings approach * update yarn.lock * change to use lib reporter Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stab at converting Gatsby program reducer to Typescript.
Notes:
There is a partial stub here (for the
reporternode on theIPrograminitial state, as it raised a TS bug which I don't think is related to this change. Temp disabled it for now; could dig deeper if it is deemed a blocker.I think this also resolves a potential bug: The initial reducer state (at "bootstrapping") included a node in the redux state called
state. I think this is supposed to bestatusas per the IProgram interface.Documentation
Related Issues
#21995