Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: upgrade core-js to version 3" #25474

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Jul 2, 2020

Reverts #25158

We have some core-js issues with docs and probably other things so I'm reverting in the meanwhile

@wardpeet wardpeet requested a review from a team as a code owner July 2, 2020 12:28
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 2, 2020
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll get it next time!

@@ -45,7 +46,7 @@ if (semver.prerelease(version)) {
report.warn(
report.stripIndent(`
You are currently using a prerelease version of Node (${version}), which is not supported.
You can use this for testing, but we do not recommend it in production.
You can use this for testing, but we do not recommend it in production.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/gatsbyjs/gatsby/pull/25158/files#r443140668 prettier did this in original PR and because this reverts everything it restore previous one as well

@wardpeet wardpeet merged commit a50cd3d into master Jul 2, 2020
@wardpeet wardpeet deleted the revert-25158-feat/core-js-resolver branch July 2, 2020 13:33
@ascorbic ascorbic removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants