Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby-telemetry): Migrate is-truthy to TypeScript #25884

Merged
merged 1 commit into from
Jul 20, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const isTruthy = require(`../is-truthy`)
import { isTruthy } from "../is-truthy"

describe(`isTruthy`, () => {
it(`handles Booleans`, () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/gatsby-telemetry/src/event-storage.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const fetch = require(`node-fetch`)
const Configstore = require(`configstore`)
const { ensureDirSync } = require(`fs-extra`)

const isTruthy = require(`./is-truthy`)
import { isTruthy } from "./is-truthy"

/* The events data collection is a spooled process that
* buffers events to a local fs based buffer
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Returns true for `true`, true, positive numbers
// Returns false for `false`, false, 0, negative integers and anything else
const isTruthy = value => {
export function isTruthy(value: any): boolean {
// Return if Boolean
if (typeof value === `boolean`) return value

Expand All @@ -19,5 +19,3 @@ const isTruthy = value => {
// Default to false
return false
}

module.exports = isTruthy