Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(gatsby-source-contentful): remove deprecated and slow fixids #25948

Closed
wants to merge 3 commits into from
Closed

perf(gatsby-source-contentful): remove deprecated and slow fixids #25948

wants to merge 3 commits into from

Conversation

axe312ger
Copy link
Collaborator

Executes deprecation done in #25473 by @pvdz

@axe312ger axe312ger added the status: needs core review Currently awaiting review from Core team member label Jul 22, 2020
@axe312ger axe312ger requested a review from pvdz July 22, 2020 10:17
@axe312ger axe312ger requested a review from a team as a code owner July 22, 2020 10:17
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 22, 2020
vladar
vladar reviewed Jul 24, 2020
View reviewed changes
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing. Looks like we should update snapshots.

@vladar vladar added topic: source-contentful Related to Gatsby's integration with Contentful and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jul 24, 2020
@pvdz pvdz removed the status: needs core review Currently awaiting review from Core team member label Jul 28, 2020
@pvdz
Copy link
Contributor

pvdz commented Jul 29, 2020

Not sure I understand why tests are failing now

@axe312ger axe312ger force-pushed the contentful-next branch 3 times, most recently from e5487e1 to d08ec08 Compare August 5, 2020 09:42
@axe312ger axe312ger force-pushed the refactor/remove-fix-ids branch 2 times, most recently from 1044b27 to f9b1286 Compare August 5, 2020 13:54
@axe312ger axe312ger mentioned this pull request Oct 2, 2020
Open
@axe312ger axe312ger force-pushed the refactor/remove-fix-ids branch from f9b1286 to a4a3e6c Compare October 6, 2020 13:18
@axe312ger axe312ger requested a review from smthomas as a code owner October 6, 2020 13:18
@axe312ger axe312ger changed the base branch from contentful-next to master October 6, 2020 13:19
@pvdz pvdz mentioned this pull request Oct 7, 2020
Merged
@wardpeet
Copy link
Contributor

wardpeet commented Oct 7, 2020

Closing because of #27318

@wardpeet wardpeet closed this Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladar vladar vladar left review comments

@pvdz pvdz Awaiting requested review from pvdz

@smthomas smthomas Awaiting requested review from smthomas

Assignees
No one assigned
Labels
topic: source-contentful Related to Gatsby's integration with Contentful
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@axe312ger @pvdz @wardpeet @vladar