Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby-plugin-sharp, gatsby-transformer-sharp): update dependencies #26259

Merged
merged 12 commits into from
Aug 28, 2020

Conversation

hoobdeebla
Copy link
Contributor

@hoobdeebla hoobdeebla commented Aug 6, 2020

Description

Updates dependencies of gatsby-plugin-sharp and gatsby-transformer-sharp to the latest Node 10.13-compatible versions. got was updated to version 10 as got@11 is incompatible with Node <10.19. Also updates probe-image-size in gatsby-remark-copy-linked-files and sharp in gatsby-plugin-manifest and gatsby-remark-images-contentful.

Semver-Major Updates

dependency old new
async ^2.6.3 ^3.2.0
fs-extra ^8.1.0 ^9.0.1
got ^8.3.2 ^10.7.0
imagemin ^6.1.0 ^7.0.1
imagemin-mozjpeg ^8.0.0 ^9.0.0
imagemin-pngquant ^6.0.1 ^9.0.0
probe-image-size ^4.1.1 ^5.0.0

Relevant Breaking Changes

async: no API changes used by these modules
fs-extra: require Node 10; no API changes used by these modules
got v9: require Node 8; no API changes used by these modules
got v10: require Node 10; change the json option to accept an object instead of a boolean and to only be responsible for the request, not the response (packages/gatsby-plugin-sharp/src/scheduler.js#L58) - got.post({body: {x: true}, json: true}); got.post({json: {x: true}, responseType: 'json'});
imagemin: require Node 8; no API changes used by these modules
imagemin-mozjpeg: require Node 10; no API changes
imagemin-pngquant v7: change the quality option to accept an array of min and max elements and use fractional numbers (packages/gatsby-plugin-sharp/src/process-file.js#L197) - {quality: '60-80'}{quality: [0.6, 0.8]}
imagemin-pngquant v8: require Node 8; no API changes
imagemin-pngquant v9: require Node 10; no API changes
probe-image-size: no API changes

@hoobdeebla hoobdeebla requested a review from a team as a code owner August 6, 2020 04:23
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 6, 2020
@pieh pieh added topic: media Related to gatsby-plugin-image, or general image/media processing topics type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Aug 6, 2020
@hoobdeebla
Copy link
Contributor Author

@wardpeet, anything I can do to help get this merged?

@hoobdeebla
Copy link
Contributor Author

Hello @wardpeet, I would very much appreciate a review.

@wardpeet
Copy link
Contributor

Sorry @hoobdeebla, i'll be checking it out as we speak :)

Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small remark :) looks good! thanks for taking the time

packages/gatsby-plugin-sharp/src/scheduler.js Outdated Show resolved Hide resolved
@hoobdeebla
Copy link
Contributor Author

All fixed, all green. Thank you for the review!

@hoobdeebla hoobdeebla requested a review from wardpeet August 27, 2020 17:15
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for fixing and upgrading

@wardpeet wardpeet merged commit dedd37f into gatsbyjs:master Aug 28, 2020
@hoobdeebla hoobdeebla deleted the plugin-sharp-node-10 branch August 28, 2020 18:37
wardpeet added a commit to wardpeet/gatsby that referenced this pull request Sep 8, 2020
wardpeet added a commit that referenced this pull request Sep 8, 2020
…dependencies (#26259)" (#26826)

This reverts commit dedd37f.

Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants