-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gatsby-plugin-sharp, gatsby-transformer-sharp): update dependencies #26259
Conversation
@wardpeet, anything I can do to help get this merged? |
Hello @wardpeet, I would very much appreciate a review. |
Sorry @hoobdeebla, i'll be checking it out as we speak :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 small remark :) looks good! thanks for taking the time
All fixed, all green. Thank you for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for fixing and upgrading
…dependencies (gatsbyjs#26259)" This reverts commit dedd37f.
Description
Updates dependencies of gatsby-plugin-sharp and gatsby-transformer-sharp to the latest Node 10.13-compatible versions. got was updated to version 10 as got@11 is incompatible with Node <10.19. Also updates probe-image-size in gatsby-remark-copy-linked-files and sharp in gatsby-plugin-manifest and gatsby-remark-images-contentful.
Semver-Major Updates
^2.6.3
^3.2.0
^8.1.0
^9.0.1
^8.3.2
^10.7.0
^6.1.0
^7.0.1
^8.0.0
^9.0.0
^6.0.1
^9.0.0
^4.1.1
^5.0.0
Relevant Breaking Changes
async: no API changes used by these modules
fs-extra: require Node 10; no API changes used by these modules
got v9: require Node 8; no API changes used by these modules
got v10: require Node 10; change the
json
option to accept an object instead of a boolean and to only be responsible for the request, not the response (packages/gatsby-plugin-sharp/src/scheduler.js#L58) -got.post({body: {x: true}, json: true});
→got.post({json: {x: true}, responseType: 'json'});
imagemin: require Node 8; no API changes used by these modules
imagemin-mozjpeg: require Node 10; no API changes
imagemin-pngquant v7: change the
quality
option to accept an array of min and max elements and use fractional numbers (packages/gatsby-plugin-sharp/src/process-file.js#L197) -{quality: '60-80'}
→{quality: [0.6, 0.8]}
imagemin-pngquant v8: require Node 8; no API changes
imagemin-pngquant v9: require Node 10; no API changes
probe-image-size: no API changes