Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update some nonbreaking major packages #26709

Closed
wants to merge 44 commits into from
Closed

chore: update some nonbreaking major packages #26709

Show file tree
Hide file tree
Changes from 37 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
e2ab194
chore(gatsby): update babel-plugin-add-module-exports
hoobdeebla Aug 30, 2020
8aba54e
perf(gatsby): enable parallel terser runs on WSL
hoobdeebla Aug 30, 2020
5380de4
chore: update better-opn, v8-compile-cache, react-refresh
hoobdeebla Aug 30, 2020
ef75cf3
Revert "perf(gatsby): enable parallel terser runs on WSL"
hoobdeebla Aug 30, 2020
0959f02
chore: update micromatch, null-loader, string-similarity
hoobdeebla Aug 30, 2020
9b80729
chore: update find-yarn-workspace-root, parse-numeric-range, preval.m…
hoobdeebla Aug 30, 2020
7f50eb9
chore: update graphql-tools packages, eslint-related packages, docume…
hoobdeebla Aug 30, 2020
d727bf4
chore(gatsby): remove @types/webpack-merge
hoobdeebla Aug 31, 2020
13e875e
chore: update fast-levenshtein, markdown-magic, mini-css-extract-plug…
hoobdeebla Aug 31, 2020
694f9e6
fix(gatsby-recipes): switch from isomorphic-fetch to cross-fetch
hoobdeebla Aug 31, 2020
7d51ceb
chore: update md5-file, mkdirp, p-queue, pify, puppeteer, tmp-promise…
hoobdeebla Aug 31, 2020
3d26f5f
chore(gatsby-theme): update globby and inquirer, remove duplicate glo…
hoobdeebla Aug 31, 2020
076a890
Merge branch 'master' into gatsby-nonbreaking-major
hoobdeebla Aug 31, 2020
d0e0849
test(gatsby-recipes): update snapshot
hoobdeebla Aug 31, 2020
c232473
Merge branch 'master' into gatsby-nonbreaking-major
hoobdeebla Sep 1, 2020
4fdbb2b
chore: update axios, guess-webpack, jest-environment-jsdom-fourteen, …
hoobdeebla Sep 2, 2020
1e5da4c
chore: update change-case, debug, file-type, got, jest-worker, json2c…
hoobdeebla Sep 2, 2020
0fce86f
chore: update cache-manager, coffee-loader, execa, rollup plugins, su…
hoobdeebla Sep 2, 2020
ce025e5
Merge branch 'master' into gatsby-nonbreaking-major
hoobdeebla Sep 2, 2020
b720063
Merge branch 'master' into gatsby-nonbreaking-major
hoobdeebla Sep 2, 2020
c0cddb1
chore: update react-docgen, xlsx, zipkin
hoobdeebla Sep 5, 2020
0b1fc11
chore: update fs-extra, remove duplicate monorepo devDeps from packages
hoobdeebla Sep 5, 2020
dcfd7a1
Merge branch 'master' into gatsby-nonbreaking-major
hoobdeebla Sep 5, 2020
7a2e987
chore(gatsby-recipes): remove unused acorn deps
hoobdeebla Sep 6, 2020
cd30c0b
chore: update agadoo, ast-types, babel-plugin-react-css-modules, comm…
hoobdeebla Sep 6, 2020
e22e39c
Merge branch 'master' into gatsby-nonbreaking-major
hoobdeebla Sep 7, 2020
dc59a3e
test(gatsby-recipes): update gatsby-plugin-manifest README snapshot
hoobdeebla Sep 7, 2020
dfbac05
Merge branch 'master' into gatsby-nonbreaking-major
hoobdeebla Sep 8, 2020
0db97d4
test(gatsby-recipes): update snapshot
hoobdeebla Sep 8, 2020
233dd05
Merge branch 'master' into gatsby-nonbreaking-major
hoobdeebla Sep 8, 2020
342df3b
chore(gatsby-recipes): update rollup and plugin test snapshot
hoobdeebla Sep 8, 2020
846f060
chore: update mini-css-extract-plugin, update-notifier, whatwg-fetch,…
hoobdeebla Sep 8, 2020
3cdde0b
Merge branch 'master' into gatsby-nonbreaking-major
hoobdeebla Sep 10, 2020
c6c354f
chore: yarn
hoobdeebla Sep 10, 2020
2251a90
chore: update yargs
hoobdeebla Sep 10, 2020
f588d32
fix: revert breaking yargs update
hoobdeebla Sep 10, 2020
48656d1
chore(monorepo): update danger, husky, lint-staged
hoobdeebla Sep 11, 2020
fede07f
test: update jest to v25
hoobdeebla Sep 11, 2020
bcc956a
chore: update @contentful/rich-text-types, chalk, friendly-errors-web…
hoobdeebla Sep 11, 2020
dd8123a
chore: update contentful-management, mini-css-extract-plugin, xlsx
hoobdeebla Sep 12, 2020
ec3924a
chore: update ast-types, yurnalist
hoobdeebla Sep 13, 2020
cb394b1
Merge branch 'master' into gatsby-nonbreaking-major
hoobdeebla Sep 14, 2020
012ce31
chore: update prefresh, subfont, webpack-virtual-modules, yurnalist
hoobdeebla Sep 14, 2020
9184b31
chore: update file-type, graphql-request, graphql
hoobdeebla Sep 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 19 additions & 30 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"@babel/node": "^7.10.3",
"@babel/plugin-transform-typescript": "^7.10.3",
"@babel/runtime": "^7.10.3",
"@lerna/prompt": "3.18.5",
"@lerna/prompt": "^3.18.5",
"@types/babel__code-frame": "^7.0.1",
"@types/better-queue": "^3.8.2",
"@types/bluebird": "^3.5.30",
Expand All @@ -13,8 +13,7 @@
"@types/eslint": "^6.1.8",
"@types/express": "^4.17.3",
"@types/fast-levenshtein": "^0.0.1",
"@types/fs-extra": "^8.1.0",
"@types/got": "^9.6.9",
"@types/fs-extra": "^9.0.1",
"@types/jaeger-client": "^3.15.4",
"@types/jest": "^24.9.1",
"@types/joi": "^14.3.4",
Expand All @@ -27,15 +26,14 @@
"@types/signal-exit": "^3.0.0",
"@types/stack-trace": "^0.0.29",
"@types/webpack": "^4.41.18",
"@types/webpack-merge": "^4.1.5",
"@typescript-eslint/eslint-plugin": "^2.24.0",
"@typescript-eslint/parser": "^2.24.0",
"@typescript-eslint/eslint-plugin": "^2.34.0",
"@typescript-eslint/parser": "^2.34.0",
"babel-eslint": "^10.1.0",
"babel-jest": "^24.9.0",
"chalk": "^2.4.2",
"chokidar": "^3.4.2",
"cross-env": "^5.2.1",
"danger": "^8.0.0",
"danger": "^10.4.0",
"date-fns": "^1.30.1",
"eslint": "^5.16.0",
"eslint-config-google": "^0.14.0",
Expand All @@ -46,24 +44,24 @@
"eslint-plugin-jsx-a11y": "^6.3.1",
"eslint-plugin-prettier": "^3.1.4",
"eslint-plugin-react": "^7.20.6",
"fs-extra": "^8.1.0",
"fs-extra": "^9.0.1",
"glob": "^7.1.6",
"husky": "3.1.0",
"husky": "^4.3.0",
"ignore": "^5.1.8",
"jest": "^24.9.0",
"jest-cli": "^24.9.0",
"jest-environment-jsdom-fourteen": "^0.1.0",
"jest-environment-jsdom-fourteen": "^1.0.1",
"jest-junit": "^10.0.0",
"jest-serializer-path": "^0.1.15",
"jest-silent-reporter": "^0.2.1",
"joi": "^14.3.1",
"js-yaml": "^3.14.0",
"lerna": "^3.22.1",
"lint-staged": "^8.2.1",
"markdown-magic": "^0.2.1",
"lint-staged": "^10.3.0",
"markdown-magic": "^1.0.0",
"npm-packlist": "^2.1.2",
"npm-run-all": "4.1.5",
"plop": "^1.9.1",
"npm-run-all": "^4.1.5",
"plop": "^2.7.4",
"prettier": "2.0.5",
"remark": "^12.0.0",
"remark-cli": "^8.0.0",
Expand All @@ -82,15 +80,15 @@
"retext-redundant-acronyms": "^3.0.0",
"retext-sentence-spacing": "^4.0.0",
"rimraf": "^3.0.2",
"svgo": "1.3.2",
"svgo": "^1.3.2",
"ts-jest": "^22",
"typescript": "^3.9.5",
"unified": "^9.0.0",
"yargs": "^10.1.2"
"yargs": "^15.4.1"
},
"resolutions": {
"theme-ui": "0.4.0-rc.1",
"csstype": "2.6.10"
"csstype": "^2.6.13"
},
"engines": {
"yarn": "^1.17.3",
Expand All @@ -102,18 +100,9 @@
],
"private": true,
"lint-staged": {
"*.{js,jsx,ts,tsx}": [
"eslint --cache --ext .js,.jsx,.ts,.tsx --fix",
"git add"
],
"*.{md,css,scss,yaml,yml}": [
"prettier --write",
"git add"
],
"*.svg": [
"svgo --pretty --indent=2 --config=svgo.yml --multipass",
"git add"
]
"*.{js,jsx,ts,tsx}": "eslint --cache --ext .js,.jsx,.ts,.tsx --fix",
"*.{md,css,scss,yaml,yml}": "prettier --write",
"*.svg": "svgo --pretty --indent=2 --config=svgo.yml --multipass"
},
"husky": {
"hooks": {
Expand Down Expand Up @@ -164,7 +153,7 @@
],
"dependencies": {
"dictionary-en": "^3.0.1",
"jest-matchmedia-mock": "^1.0.1",
"jest-matchmedia-mock": "^1.1.0",
"retext-emoji": "^7.0.1",
"retext-spell": "^4.0.0",
"retext-syntax-mentions": "^2.1.1",
Expand Down
14 changes: 6 additions & 8 deletions packages/gatsby-admin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,12 @@
},
"homepage": "https://github.com/gatsbyjs/gatsby/tree/master/packages/gatsby-admin#readme",
"devDependencies": {
"@emotion/core": "^10.0.28",
"@emotion/core": "^10.0.35",
"@emotion/styled": "^10.0.27",
"@types/react-instantsearch-dom": "^5.2.6",
"@typescript-eslint/eslint-plugin": "^2.28.0",
"@typescript-eslint/parser": "^2.28.0",
"csstype": "^2.6.10",
"csstype": "^2.6.13",
"feedback-fish": "^0.1.12",
"formik": "^2.1.4",
"formik": "^2.1.5",
"gatsby": "^2.24.57",
"gatsby-interface": "0.0.183",
"gatsby-plugin-typescript": "^2.4.19",
Expand All @@ -38,11 +36,11 @@
"remove-markdown": "^0.3.0",
"rimraf": "^3.0.2",
"strict-ui": "^0.2.0-0",
"subscriptions-transport-ws": "^0.9.16",
"subscriptions-transport-ws": "^0.9.18",
"theme-ui": "^0.4.0-alpha.3",
"typescript": "^3.9.5",
"urql": "^1.9.8",
"yup": "^0.29.1"
"urql": "^1.10.1",
"yup": "^0.29.3"
},
"scripts": {
"develop": "gatsby develop",
Expand Down
2 changes: 1 addition & 1 deletion packages/gatsby-admin/src/components/recipes-gui/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { createUrqlClient } from "../../urql-client"
import { useMutation, useSubscription } from "urql"

import lodash from "lodash"
import fetch from "isomorphic-fetch"
import fetch from "cross-fetch"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why switch to cross-fetch?

Suggested change
import fetch from "cross-fetch"
import fetch from "cross-fetch"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the cross-fetch README:

Why not isomorphic-fetch?
My preferred library used to be isomorphic-fetch but it has this bug that prevents it from running in a react native environment. It seems unlikely to be fixed since there haven't been any new commits to it since 2016. That means dependencies are outdated as well.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, isomorphic-fetch uses node-fetch@1, which is vulnerable to CVE-2020-15168 (disclosed yesterday).

Copy link

@G-Rath G-Rath Sep 11, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In saying that, cross-fetch uses exact version constraints so is also currently affected by the same advisory

They're released a new version that updates node-fetch 🎉

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled out this security fix into its own PR here: #26876

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @karlhorky! Beat me to it haha


import { Button, Heading } from "gatsby-interface"
import { StepRenderer } from "gatsby-recipes/components"
Expand Down
24 changes: 12 additions & 12 deletions packages/gatsby-cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,26 +13,26 @@
"@babel/code-frame": "^7.10.3",
"@hapi/joi": "^15.1.1",
"@types/common-tags": "^1.8.0",
"better-opn": "^1.0.0",
"better-opn": "^2.0.0",
"chalk": "^2.4.2",
"clipboardy": "^2.3.0",
"common-tags": "^1.8.0",
"configstore": "^5.0.1",
"convert-hrtime": "^3.0.0",
"envinfo": "^7.5.1",
"execa": "^3.4.0",
"envinfo": "^7.7.3",
"execa": "^4.0.3",
"fs-exists-cached": "^1.0.0",
"fs-extra": "^8.1.0",
"fs-extra": "^9.0.1",
"gatsby-core-utils": "^1.3.19",
"gatsby-recipes": "^0.2.24",
"gatsby-telemetry": "^1.3.32",
"hosted-git-info": "^3.0.4",
"hosted-git-info": "^3.0.5",
"ink": "^2.7.1",
"ink-spinner": "^3.1.0",
"is-valid-path": "^0.1.1",
"lodash": "^4.17.20",
"meant": "^1.0.1",
"node-fetch": "^2.6.0",
"meant": "^1.0.2",
"node-fetch": "^2.6.1",
"opentracing": "^0.14.4",
"pretty-error": "^2.1.1",
"progress": "^2.0.3",
Expand All @@ -42,19 +42,19 @@
"resolve-cwd": "^3.0.0",
"semver": "^7.3.2",
"signal-exit": "^3.0.3",
"source-map": "0.7.3",
"source-map": "^0.7.3",
"stack-trace": "^0.0.10",
"strip-ansi": "^5.2.0",
"update-notifier": "^4.1.0",
"strip-ansi": "^6.0.0",
"update-notifier": "^4.1.1",
"uuid": "3.4.0",
"yargs": "^15.3.1",
"yargs": "^15.4.1",
"yurnalist": "^1.1.2"
},
"devDependencies": {
"@babel/cli": "^7.10.3",
"@babel/core": "^7.10.3",
"@types/hosted-git-info": "^3.0.0",
"@types/yargs": "^15.0.4",
"@types/yargs": "^15.0.5",
"babel-preset-gatsby-package": "^0.5.2",
"cross-env": "^5.2.1",
"rimraf": "^3.0.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/gatsby-codemods/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"@babel/core": "^7.10.3",
"babel-preset-gatsby-package": "^0.5.2",
"cross-env": "^5.2.1",
"jscodeshift": "^0.7.0"
"jscodeshift": "^0.11.0"
},
"engines": {
"node": ">=10.13.0"
Expand Down
6 changes: 3 additions & 3 deletions packages/gatsby-core-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@
"dist/"
],
"dependencies": {
"ci-info": "2.0.0",
"ci-info": "^2.0.0",
"configstore": "^5.0.1",
"fs-extra": "^8.1.0",
"fs-extra": "^9.0.1",
"node-object-hash": "^2.0.0",
"proper-lockfile": "^4.1.1",
"tmp": "^0.2.1",
Expand All @@ -40,7 +40,7 @@
"devDependencies": {
"@babel/cli": "^7.10.3",
"@babel/core": "^7.10.3",
"@types/ci-info": "2.0.0",
"@types/ci-info": "^2.0.0",
"babel-preset-gatsby-package": "^0.5.2",
"cross-env": "^5.2.1",
"typescript": "^3.9.5"
Expand Down
6 changes: 3 additions & 3 deletions packages/gatsby-design-tokens/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@
"hex2rgba": "^0.0.1"
},
"devDependencies": {
"agadoo": "^1.1.0",
"agadoo": "^2.0.0",
"cross-env": "^5.2.1",
"microbundle": "^0.12.2",
"preval.macro": "^3.0.0"
"microbundle": "^0.12.3",
"preval.macro": "^5.0.0"
},
"engines": {
"node": ">=10.13.0"
Expand Down
10 changes: 5 additions & 5 deletions packages/gatsby-dev-cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@
"chokidar": "^3.4.2",
"configstore": "^5.0.1",
"del": "^5.1.0",
"execa": "^3.4.0",
"find-yarn-workspace-root": "^1.2.1",
"fs-extra": "^8.1.0",
"execa": "^4.0.3",
"find-yarn-workspace-root": "^2.0.0",
"fs-extra": "^9.0.1",
"is-absolute": "^1.0.0",
"lodash": "^4.17.20",
"request": "2.88.2",
"signal-exit": "^3.0.3",
"verdaccio": "^4.7.2",
"yargs": "^15.3.1"
"verdaccio": "^4.8.1",
"yargs": "^15.4.1"
},
"devDependencies": {
"@babel/cli": "^7.10.3",
Expand Down
4 changes: 2 additions & 2 deletions packages/gatsby-graphiql-explorer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,13 @@
"graphiql-code-exporter": "^2.0.8",
"graphiql-explorer": "^0.6.2",
"html-webpack-plugin": "^3.2.0",
"npm-run-all": "4.1.5",
"npm-run-all": "^4.1.5",
"react": "^16.12.0",
"react-dom": "^16.12.0",
"style-loader": "^0.23.1",
"webpack": "^4.44.1",
"webpack-cli": "^3.3.12",
"whatwg-fetch": "^3.4.0"
"whatwg-fetch": "^3.4.1"
},
"engines": {
"node": ">=10.13.0"
Expand Down
8 changes: 4 additions & 4 deletions packages/gatsby-legacy-polyfills/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@
"core-js": "^3.6.5",
"cpy-cli": "^3.1.1",
"cross-env": "^5.2.1",
"execa": "^4.0.2",
"execa": "^4.0.3",
"fs-extra": "^9.0.1",
"microbundle": "^0.12.0",
"microbundle": "^0.12.3",
"npm-run-all": "^4.1.5",
"object-assign": "^4.1.1",
"source-map": "^0.7.3",
"url-polyfill": "^1.1.9",
"whatwg-fetch": "^3.4.0"
"url-polyfill": "^1.1.10",
"whatwg-fetch": "^3.4.1"
}
}
2 changes: 1 addition & 1 deletion packages/gatsby-page-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"gatsby-core-utils": "^1.3.19",
"glob": "^7.1.6",
"lodash": "^4.17.20",
"micromatch": "^3.1.10"
"micromatch": "^4.0.2"
},
"devDependencies": {
"@babel/cli": "^7.10.3",
Expand Down
8 changes: 4 additions & 4 deletions packages/gatsby-page-utils/src/ignore-path.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import * as mm from "micromatch"
import { isMatch, Options as mmOptions } from "micromatch"

interface IPathIgnoreOptions {
patterns?: string | ReadonlyArray<string>
options?: mm.Options
options?: mmOptions
}

export function ignorePath(
Expand All @@ -13,7 +13,7 @@ export function ignorePath(
if (!ignore) return false
const settings: {
patterns: string | ReadonlyArray<string>
options: mm.Options
options: mmOptions
} = {
patterns: ``,
options: {},
Expand All @@ -37,5 +37,5 @@ export function ignorePath(
settings.patterns = ignore.patterns
}
}
return mm.any(path, settings.patterns, settings.options)
return isMatch(path, settings.patterns, settings.options)
}
4 changes: 2 additions & 2 deletions packages/gatsby-page-utils/src/validate-path.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { parse } from "path"
import * as mm from "micromatch"
import { isMatch } from "micromatch"

const tsDeclarationExtTest = /\.d\.tsx?$/
const jsonYamlExtTest = /\.(json|ya?ml)$/
Expand All @@ -11,7 +11,7 @@ function isTestFile(filePath: string): boolean {
`**/(*.)+(spec|test).(js|ts|jsx|tsx)`,
]

return mm.isMatch(filePath, testPatterns)
return isMatch(filePath, testPatterns)
}

export function validatePath(path: string): boolean {
Expand Down
2 changes: 1 addition & 1 deletion packages/gatsby-plugin-benchmark-reporting/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
},
"dependencies": {
"fast-glob": "^3.2.4",
"node-fetch": "^2.6.0",
"node-fetch": "^2.6.1",
"uuid": "3.4.0"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/gatsby-plugin-catch-links/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
},
"dependencies": {
"@babel/runtime": "^7.10.3",
"escape-string-regexp": "^1.0.5"
"escape-string-regexp": "^4.0.0"
},
"devDependencies": {
"@babel/cli": "^7.10.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/gatsby-plugin-coffeescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
],
"dependencies": {
"@babel/runtime": "^7.10.3",
"coffee-loader": "^0.9.0",
"coffee-loader": "^1.0.0",
"coffee-react-transform": "^5.0.0",
"coffeescript": "^2.5.1"
},
Expand Down
Loading