-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kylegach.com to list of sites #270
Conversation
Gorgeous site! Looking forward to your contributions! :-) To your questions. To get urls w/o the trailing slash working, this is something you have to enable on your serve. How apache/nginx/etc generally work by default is they a) try to load the url directly e.g. example.com/a-file.html gets mapped to an actually I don't have time to debug why your other toml config file isn't loading (it should) but this is the Webpack config — https://github.com/gatsbyjs/gatsby/blob/master/lib/utils/webpack.config.js#L178 if you find the problem, a bug-fix PR would be highly appreciated! I'm not sure why the "cut the mustard" technique isn't working for you. As long as the JS is set using |
Thank you for the kind words and insights, Kyle. And I’m honored that you read some of my writing! I’ll give some of your suggestions for my issues a try and post back with results. I’m quite interested in both of those issues. You might have noticed that the performance post was just “Part 1”. Part 2 will be stripping out unused CSS and inlining the result. I figured for a site as stylistic simple as mine, this would be a much easier approach than determining the truly critical, above the fold CSS... but I ran into some issues with the only suitable tool I could find. Part 3 is likely to be removing React from the client-side (that ~200 Kb payload just isn’t worth the barely-faster repeat views, imo), and Part 4, if I can make it work, will be a service worker implementation. |
Sounds great! Looking forward to future parts. Frontend performance has been a hobby of mine for a while. webpagetest.org and I are buds :-) On the 200kb js bundle — would you feel differently with code splitting? E.g. if a first-time visitor only loaded say ~60kb? |
I may have misunderstood how code splitting works and which situations it benefits. That would certainly sway my opinion, though perhaps not enough to change the decision. Btw, is there a better place for these sorts of conversations than here? I don't want to add too much noise to the issues/PRs. |
Right now Gatsby puts in the bundle.js all JS modules & page data (HTML, etc.) from the entire site. Code splitting means merely that when loading a page say the front page you'd only load the JS & data for that page. Then when navigating to another page, your site would load a new bundle for that page and so on. See #10 for more. What sort of place were you thinking of? As far as I'm concerned issues/PRs are the place for conversations :-) Everything we're talking about here is on topic. |
Hiya @kylegach! 👋 This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here. Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! 💪💜 |
Thanks, @jlengstorf! I'll certainly take you up on both. :) Btw, I created the site referenced by this PR to get a job (it worked! 🎉), and I'll be updating it to use the latest Gatsby soon, as I'm in the market again. Looking forward to taking advantage of all the additional features and improvements the team has made. |
Thanks for the great tool! Be sure to check the Colophon. :)
I still have lots of ideas for improvements (some of which I’ll explore submitting for PRs), but there are a few things that I’d appreciate help with, if you’re feeling generous:
config.js.head
here) in thehead
, because it needs to reference thebody
and the JS apparently executes during the build process?Thank you again for the wonderful tool. Now that I’ve published my work, I hope to begin contributing.