Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Updates for the Square payments example #27263

Conversation

jonniebigodes
Copy link

With this pull request the issue #26055 is partially addressed. As i've mentioned in a comment in said issue i was tasked with adjusting the example and starter.

What was done:

  • The example's Gatsby dependencies were updated and simplified.
  • Included the serverless function (netlify) and necessary dependencies and configurations.
  • Updated the src/paymentForm to include the call to the serverless function.
  • Renamed page-2 to paymentreciept and updated the file contents to display the payment receipt information obtained from Square api.

Feel free to provide feedback

jonniebigodes and others added 5 commits February 21, 2020 19:44
update gatsby fork for further fixing errors on the starter submission
april update gatsby fork
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 3, 2020
@LekoArts LekoArts added hacktoberfest-accepted type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 5, 2020
@pvdz pvdz changed the title Updates for the Square payments example chore(docs): Updates for the Square payments example Oct 5, 2020
@pvdz
Copy link
Contributor

pvdz commented Oct 5, 2020

(-> #27272 ?)

@jonniebigodes
Copy link
Author

@pvdz as i've mentioned in the underlying docs i updated the starter and example to match the latest version of the dependencies. @LekoArts already addressed the author of said pull request on how we could proceed.

Let me know if you need anything else and we'll move from there, sounds good?

@jonniebigodes
Copy link
Author

Just a friendly reminder of the status on this pull request? Is this ok to go? Or not. Regarding the conflicts someone else with admin rights will have to take care of them.

Stay safe

@pvdz
Copy link
Contributor

pvdz commented Jan 4, 2021

Hey. I'll have to defer to @meganesu for this one. My comment before was not a review but a quick triage. Sorry about the delay.

@LekoArts
Copy link
Contributor

LekoArts commented Aug 8, 2022

Hey! Thanks so much for opening this pull request!

Sadly this PR got stale and didn't have any activity for some time. We're trying to do better with PR reviews! To get a better overview of all actionable PRs we're going through all open PRs and triage them. Since we won't be able to do everything and adding new features always means added maintenance burden, we have to be more picky about what's beneficial for the average user and the project itself longterm.

Having said all this, we dropped the ball on this PR and we're sorry about not responding to it earlier. As said above, we want to do better in the future but here we should have communicated earlier what will happen with the PR.

Unfortunately we won't merge this PR at the moment because with #36268 the page got actually removed.

We absolutely want to have you as a contributor and are sorry for any inconveniences we caused with replying too late to this PR.

Thanks for submitting to Gatsby! 💜

@LekoArts LekoArts closed this Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants