-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): Updates for the Square payments example #27263
chore(docs): Updates for the Square payments example #27263
Conversation
update gatsby fork for further fixing errors on the starter submission
april update gatsby fork
april update fork
august update
(-> #27272 ?) |
Just a friendly reminder of the status on this pull request? Is this ok to go? Or not. Regarding the conflicts someone else with admin rights will have to take care of them. Stay safe |
Hey. I'll have to defer to @meganesu for this one. My comment before was not a review but a quick triage. Sorry about the delay. |
Hey! Thanks so much for opening this pull request! Sadly this PR got stale and didn't have any activity for some time. We're trying to do better with PR reviews! To get a better overview of all actionable PRs we're going through all open PRs and triage them. Since we won't be able to do everything and adding new features always means added maintenance burden, we have to be more picky about what's beneficial for the average user and the project itself longterm. Having said all this, we dropped the ball on this PR and we're sorry about not responding to it earlier. As said above, we want to do better in the future but here we should have communicated earlier what will happen with the PR. Unfortunately we won't merge this PR at the moment because with #36268 the page got actually removed. We absolutely want to have you as a contributor and are sorry for any inconveniences we caused with replying too late to this PR. Thanks for submitting to Gatsby! 💜 |
With this pull request the issue #26055 is partially addressed. As i've mentioned in a comment in said issue i was tasked with adjusting the example and starter.
What was done:
src/paymentForm
to include the call to the serverless function.page-2
topaymentreciept
and updated the file contents to display the payment receipt information obtained from Square api.Feel free to provide feedback