chore(docs): replace typefaces with fontsource #27313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
|
Just finished updating the typeface packages w/ the deprecation notice https://www.npmjs.com/package/typeface-vesper-libre |
KyleAMathews
previously approved these changes
Oct 6, 2020
LekoArts
added
type: documentation
ascorbic
added
the
status: needs docs review
meganesu
suggested changes
Oct 29, 2020
Co-authored-by: Megan Sullivan <meganesulli@gmail.com>
ayuhito
commented
Oct 30, 2020
meganesu
reviewed
Nov 7, 2020
|
Should be almost good to go! |
meganesu
approved these changes
Nov 16, 2020
|
@meganesu, nothing else comes to mind. LGTM. |
This was referenced Jul 22, 2022
This was referenced Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the documentation for Gatsby's local hosting font solutions which was previously dependent on Typefaces to Fontsource.
Kyle and I were discussing this privately and he stated that he is deprecating the Typefaces project and no longer maintaining it in favour of Fontsource. The latest commits on his repo should reflect that and we're working on making a couple last changes.
Documentation
The two docs that were changed:
@gatsbyjs/documentation