Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby): Migrate query-watcher to ts #27324

Merged
merged 4 commits into from
Oct 9, 2020
Merged

chore(gatsby): Migrate query-watcher to ts #27324

merged 4 commits into from
Oct 9, 2020

Conversation

ArcaneDiver
Copy link
Contributor

@ArcaneDiver ArcaneDiver commented Oct 7, 2020 •
edited
Loading

Description

Migration of gatsby/src/query/query-watcher.js to TypeScript

Related Issues

Related to #21995 (comment)

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 7, 2020
@ArcaneDiver
Copy link
Contributor Author

I temporarily close the PR to fix some bugs

@ArcaneDiver ArcaneDiver closed this Oct 7, 2020
@ArcaneDiver ArcaneDiver reopened this Oct 7, 2020
ascorbic
ascorbic reviewed Oct 8, 2020
View reviewed changes
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks. Just a couple of minor requests

packages/gatsby/src/query/query-watcher.ts Outdated Show resolved Hide resolved
packages/gatsby/src/query/query-watcher.ts Outdated Show resolved Hide resolved
@ascorbic ascorbic added status: awaiting author response Additional information has been requested from the author topic: TypeScript migration and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 8, 2020
@ascorbic ascorbic mentioned this pull request Oct 8, 2020
Closed
@ascorbic ascorbic self-assigned this Oct 8, 2020
@ArcaneDiver ArcaneDiver requested a review from ascorbic October 9, 2020 08:40
ascorbic
ascorbic approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

@ascorbic ascorbic merged commit 69e5097 into gatsbyjs:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascorbic ascorbic ascorbic approved these changes

Assignees

@ascorbic ascorbic

Labels
status: awaiting author response Additional information has been requested from the author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArcaneDiver @ascorbic