-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gatsby-plugin-netlify): add pluginOptionsSchema export #27420
Merged
mfrachet
merged 8 commits into
gatsbyjs:master
from
mfrachet:plugin-options-schema-to-netlify
Oct 13, 2020
Merged
chore(gatsby-plugin-netlify): add pluginOptionsSchema export #27420
mfrachet
merged 8 commits into
gatsbyjs:master
from
mfrachet:plugin-options-schema-to-netlify
Oct 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Oct 13, 2020
mfrachet
removed
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Oct 13, 2020
mxstbr
reviewed
Oct 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks fantastic but I'd love to see descriptions added!
mxstbr
previously approved these changes
Oct 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic! 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add plugin options schema to gatsby-plugin-netlify.
Here are the potential options to pass to the plugin:
Notes:
headers
is a specific netlify type corresponding to{ [key: string]: Array<string> }
(See details)transformHeaders
is a function, but I didn't find a way to tell Joi about the return type of that function. In that scenario, the return type should be of typeNetlify Headers
(see previous bullet)