chore(gatsby-plugin-offline): add pluginOptionsSchema export #27438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
mfrachet
commented
Oct 14, 2020
Comment on lines
+241
to
+247
| handler: Joi.string().valid( | ||
| `StaleWhileRevalidate`, | ||
| `CacheFirst`, | ||
| `NetworkFirst`, | ||
| `NetworkOnly`, | ||
| `CacheOnly` | ||
| ), |
There was a problem hiding this comment.
TIL: this is the way to deal with "enums" like options
There was a problem hiding this comment.
We should definitely add this to the best practices documentation we're going to write!
mfrachet
removed
the
status: triage needed
mfrachet
commented
Oct 14, 2020
mxstbr
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add plugin schema options in
gatsby-plugin-offlineRelates to #27242 and https://www.gatsbyjs.com/plugins/gatsby-plugin-offline/